Indeed, Michael. That was what you said in comments regarding:
1. https://github.com/apache/ofbiz-framework/pull/481
2. https://github.com/apache/ofbiz-framework/pull/482
3. https://github.com/apache/ofbiz-framework/pull/483
and now again in
Pierre,
When you review a commit you need to better read the commit comment.
https://github.com/apache/ofbiz-framework/commit/8a9596be849f6709cb17c24a598c4862e8df867c
clearly states:
<>
HTH
Jacques
Le 02/02/2022 à 18:00, Pierre Smits a écrit :
Hi Jacques,
With this commit
Actually that was my bad to commit my local changes that helped me to get ahead.
I should have kept them local until you resolved the issue. BTW I did not
change R22.
Please do as you prefer:
* don't wait for using SDK 11, fix the issue in both using your local code w/o
reverting
* revert
I'll not apologize either for following guidelines and practices
established, having the consensus.
Op do 3 feb. 2022 09:47 schreef Jacques Le Roux <
jacques.le.r...@les7arts.com>:
> And again (again, again, again) all depend on context. Here it's quite
> obvious that there are no labels
No worries Jacques, I revert my local fix commit, you gone faster than me.
What can I do for help, to escape any collision with you ?
Nicolas
On 03/02/2022 10:02, Jacques Le Roux wrote:
> Le 03/02/2022 à 09:54, jler...@apache.org a écrit :
>> Improved: no functional change, adds a BuildBot
Le 03/02/2022 à 09:54, jler...@apache.org a écrit :
Improved: no functional change, adds a BuildBot badge (INFRA-22807)
It works locally (once you have installed Ruby, asciidoctor and
asciidoctor-diagram). CHecking that it's also OK on BuildBot, let's see
result
And again (again, again, again) all depend on context. Here it's quite obvious
that there are no labels changes, only tabs replaced by spaces.
I though agree that it should have been another commit, just that I missed that
because I automate (too?) much things.
I'll not apologize :p
Le
I did not confirm that.
My response was targeted to the wrong assumptions that the changes were
only removes/same additions and the result of an unclean state of the
working copy.
It is generally better to separate formatting / cleanup from real
changes, which I did not mention here. For
