Re: [PROPOSAL] Migration of the Apache OFBiz website to Hugo

2023-02-07 Thread Gaurav Saini
+1 We recently built 3-4 websites in hugo and highly recommend it. Some samples: vizitorapp.netlify.com www.famstar.in On Tue, Feb 7, 2023, 23:37 Michael Brohl wrote: > Dear community, > > In the course of getting Wiebke to be able to help with our blog, it > turned out that Apache Roller wil

Re: [PROPOSAL] Migration of the Apache OFBiz website to Hugo

2023-02-07 Thread Jacques Le Roux
Hi Michael, That sounds like the best solution to me. Thanks Jacques Le 07/02/2023 à 19:06, Michael Brohl a écrit : Dear community, In the course of getting Wiebke to be able to help with our blog, it turned out that Apache Roller will be discontinued as the platform for blogs by infra [1].

Should balance sheet fixes be added to 22.01 release branch?

2023-02-07 Thread Daniel Watford
Hello, While reading through BalanceSheet.groovy - the script used to prepare data used during the rendering of the Accounting Balance Sheet report - I found that some refactoring would make the script easier to read and therefore created OFBIZ-12753. While testing the refactored implementation I

Re: Codenarc integration process

2023-02-07 Thread Daniel Watford
No, we should be able to create multiple reviews within a single PR - or perhaps add a comment to an existing review. On Tue, 7 Feb 2023 at 17:44, Jacques Le Roux wrote: > Le 07/02/2023 à 16:53, gil.portenseigne a écrit : > > yes ongoing review are private, you need to finish it to let other se

[PROPOSAL] Migration of the Apache OFBiz website to Hugo

2023-02-07 Thread Michael Brohl
Dear community, In the course of getting Wiebke to be able to help with our blog, it turned out that Apache Roller will be discontinued as the platform for blogs by infra [1]. There is an offer and already a pull request [2] to export the existing blog posts for a migration to Hugo [3]. Hugo

Re: Codenarc integration process

2023-02-07 Thread Jacques Le Roux
Le 07/02/2023 à 16:53, gil.portenseigne a écrit : yes ongoing review are private, you need to finish it to let other see your comments and suggestions. Does it mean that you need to review ALL before others see what you commented 😮 ? Thanks Jacques

Re: Codenarc integration process

2023-02-07 Thread gil.portenseigne
Hello Dan, Inline On 07/02/23 03:21, Daniel Watford wrote: > Hi Gil, > > There is a comment 'Can requestIdMap be removed?' against the > StatsSinceStart.groovy file in the PR. This comment is part of a review. > > JobDetails.groovy was marked as UNSURE as it concerned a possible feature > of Gr

Re: Codenarc integration process

2023-02-07 Thread Daniel Watford
Hi Gil, There is a comment 'Can requestIdMap be removed?' against the StatsSinceStart.groovy file in the PR. This comment is part of a review. JobDetails.groovy was marked as UNSURE as it concerned a possible feature of Groovy that I wasn't aware of and couldn't find appropriate documentation for