Re: Should balance sheet fixes be added to 22.01 release branch?

2023-02-09 Thread Nicolas Malin
No problem to fix the 22.01 with refactoring. To use the accounting component on ootb it's hard because you need had exactly the same schemes or I never the this configuration. The potential user that can use it directly is on my view, few, and appear more an help to how I will do the mine by

Re: Should balance sheet fixes be added to 22.01 release branch?

2023-02-09 Thread michael.br...@ecomify.de
+1 Thanks Daniel, Michael %PERSON% %MARKETING% %COMPANY% %LEGAL% > Am 07.02.2023 um 23:36 schrieb Daniel Watford : > > Hello, > > While reading through BalanceSheet.groovy - the script used to prepare data > used during the rendering of the Accounting Balance Sheet report - I found > that

Re: Should balance sheet fixes be added to 22.01 release branch?

2023-02-09 Thread Jacques Le Roux
+1 for 22.01 Jacques Le 09/02/2023 à 15:55, Jacopo Cappellato a écrit : Hello Dan, On Tue, Feb 7, 2023 at 11:36 PM Daniel Watford wrote: [...] - If we decide to fix the bugs in release 22.01, is it acceptable to bring in the refactored code to do so? In my opinion the refactoring has made

Re: Should balance sheet fixes be added to 22.01 release branch?

2023-02-09 Thread Jacopo Cappellato
Hello Dan, On Tue, Feb 7, 2023 at 11:36 PM Daniel Watford wrote: > > [...] > - If we decide to fix the bugs in release 22.01, is it acceptable to bring > in the refactored code to do so? In my opinion the refactoring has made it > easier to reason about the correctness of the resultant balance