Re: Buildbot failure in on ofbizTrunkFrameworkPlugins

2023-04-20 Thread Jacques Le Roux
Le 19/04/2023 à 11:24, Jacques Le Roux a écrit : Good idea about the badge. I'll have a look. Hi Daniel, It's OK for trunk build but how to cleanly differentiate ? https://ci2.apache.org/badges/ofbizTrunkFramework.svg from https://ci2.apache.org/badges/ofbizTrunkFrameworkRat.svg https://ci2.

Re: [OFBIZ-12801] "Error at CommunicationEventServices.groovy:489"

2023-04-20 Thread Michael Brohl
To have it even more clear, I would separate logic for events and services. The GroovyBaseScript in the service engine package should only be used for services and there should be another one for events, if really needed. Mixing both together is bad practice IMO. There seem to be only 7 contro

Re: [OFBIZ-12801] "Error at CommunicationEventServices.groovy:489"

2023-04-20 Thread Jacques Le Roux
Hi Daniel, I dont think there is a knowledge about methods being both services and events. I think there are not (much?) such cases. Being acquainted to OFBiz logs I did not check the trunk demo log content (now in Docker); so I wonder if there are such other cases than CommunicationEventServi

Re: Lazy consensus: Build docker container images for the release22.01 branch and demo-next site

2023-04-20 Thread Daniel Watford
Hi Michael, Those changes have been applied to trunk and release22.01. You should be able to sync your repository fork and avoid the build failures related to pushing docker images. On Thu, 20 Apr 2023 at 11:42, Michael Brohl wrote: > Hi Dan, > > sound good! > > I would propose to name the envi

Re: Create return till ...

2023-04-20 Thread Jacques Le Roux
Hi All, I stumbled upon this thread by chance. Has finally something being done? TIA Jacques Le 11/03/2019 à 12:39, Rishi Solanki a écrit : I agree with the approach what Pierre suggested to go with ProductCategoryAttribute and ProductAttribute. Because for range of products we may need diffe

Re: Lazy consensus: Build docker container images for the release22.01 branch and demo-next site

2023-04-20 Thread Michael Brohl
Hi Dan, sound good! I would propose to name the environment variable more explicitely, e.g. DO_DOCKER_PUSH. DO_PUSH sounds too broad to me. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 20.04.23 um 12:25 schrieb Daniel Watford: Hi Michael, I have just reproduced the issue you r

Re: Lazy consensus: Build docker container images for the release22.01 branch and demo-next site

2023-04-20 Thread Daniel Watford
Hi Michael, I have just reproduced the issue you raised at https://github.com/danwatford/ofbiz-framework by resyncing trunk. Yes, we can (and should) make the problematic steps skippable/optional. If you drill into the GitHub Action you will probably find the failure occurred at step, 'Build and

Re: Lazy consensus: Build docker container images for the release22.01 branch and demo-next site

2023-04-20 Thread Michael Brohl
Hi Dan, the build integration to build docker images seems to break forks and therefore external repositories. When synching our fork, a git actions seems to chime in: === Build and push docker images: All jobs have failed Build and push OFBiz docker container images Build and push docker i

Re: OFBiz 22.01 - Eclipse - Issues on setting up a debugging environment.

2023-04-20 Thread Michael Brohl
We have a working solution with all tests passing for release22.01 and trunk, I have created a Jira issue to track the effort. https://issues.apache.org/jira/browse/OFBIZ-12808 Best regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 19.04.23 um 15:52 schrieb Michael Brohl: Hi everyone