Re: about last years commits for JMS

2012-07-18 Thread Martin Kreidenweis
Hi, On 26.06.2012 18:45, Jacopo Cappellato wrote: The patch attached to OFBIZ-4453 has issues and I don't see how it can fix the problems introduced by the commits I reported at the beginning of this thread. The patch I have attached to an earlier post in this thread at least should revert

[jira] [Commented] (OFBIZ-4514) Taxes are not handled correctly when creating accounting transactions from purchase invoices

2012-03-23 Thread Martin Kreidenweis (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236663#comment-13236663 ] Martin Kreidenweis commented on OFBIZ-4514: --- Hi, I've found some time now

[jira] [Updated] (OFBIZ-4514) Taxes are not handled correctly when creating accounting transactions from purchase invoices

2012-03-23 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4514: -- Issue Type: Bug (was: Wish) I still think at least part of this issue is definitely

[jira] [Commented] (OFBIZ-4519) Order adjustment prorating does not work as expected for when creating an invoice for an order with partially canceled items

2011-10-27 Thread Martin Kreidenweis (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136986#comment-13136986 ] Martin Kreidenweis commented on OFBIZ-4519: --- OK, I looked into it in more detail

[jira] [Created] (OFBIZ-4519) Order adjustment prorating does not work as expected for when creating an invoice for an order with partially canceled items

2011-10-26 Thread Martin Kreidenweis (Created) (JIRA)
URL: https://issues.apache.org/jira/browse/OFBIZ-4519 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Martin Kreidenweis We had a problem with creating invoices for orders with partially canceled items

[jira] [Updated] (OFBIZ-4519) Order adjustment prorating does not work as expected for when creating an invoice for an order with partially canceled items

2011-10-26 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4519: -- Attachment: OFBIZ-4519.patch Order adjustment prorating does not work as expected

[jira] [Created] (OFBIZ-4520) Bulk operations for purchase invoices not working

2011-10-26 Thread Martin Kreidenweis (Created) (JIRA)
Affects Versions: SVN trunk Reporter: Martin Kreidenweis Priority: Minor Attachments: OFBIZ-4520.patch There are JavaScript in the bulk operations section in the AP Purchase Invoices Screen that prevent the bulk action button from being clicked. So e.g. bulk

[jira] [Updated] (OFBIZ-4520) Bulk operations for purchase invoices not working

2011-10-26 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4520: -- Attachment: OFBIZ-4520.patch Bulk operations for purchase invoices not working

[jira] [Updated] (OFBIZ-4520) Bulk operations for purchase invoices not working

2011-10-26 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4520: -- Attachment: OFBIZ-4520.patch Bulk operations for purchase invoices not working

[jira] [Updated] (OFBIZ-4520) Bulk operations for purchase invoices not working

2011-10-26 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4520: -- Attachment: (was: OFBIZ-4520.patch) Bulk operations for purchase invoices

[jira] [Created] (OFBIZ-4513) Make customer refunds possible for billing account payments

2011-10-25 Thread Martin Kreidenweis (Created) (JIRA)
Components: accounting Affects Versions: SVN trunk Reporter: Martin Kreidenweis We at [Lusini|http://www.lusini.de/] made customer refunds possible for billing account payments. The following changes were done: * changed BillingAccountWorker ** now considers refunded payments

[jira] [Updated] (OFBIZ-4513) Make customer refunds possible for billing account payments

2011-10-25 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4513: -- Attachment: OFBIZ-4513.patch the patch as described above Make

[jira] [Created] (OFBIZ-4514) Taxes are not handled correctly when creating accounting transactions from purchase invoices

2011-10-25 Thread Martin Kreidenweis (Created) (JIRA)
Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: SVN trunk Reporter: Martin Kreidenweis Taxes are not handled correctly when creating accounting transactions from purchase invoices in GeneralLedgerServices

[jira] [Updated] (OFBIZ-4514) Taxes are not handled correctly when creating accounting transactions from purchase invoices

2011-10-25 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4514: -- Attachment: OFBIZ-4514.patch patch to handle taxes in purchase invoices similar

[jira] [Created] (OFBIZ-4515) typo in javascript prevents live update of content

2011-10-25 Thread Martin Kreidenweis (Created) (JIRA)
, order Affects Versions: SVN trunk Reporter: Martin Kreidenweis Priority: Minor Attachments: OFBIZ-4515.patch success is mistyped as succes in PurchaseInvoices.ftl and order.js -- This message is automatically generated by JIRA. If you think it was sent incorrectly

[jira] [Updated] (OFBIZ-4515) typo in javascript prevents live update of content

2011-10-25 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4515: -- Attachment: OFBIZ-4515.patch patch typo in javascript prevents live

[jira] [Created] (OFBIZ-4516) OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice

2011-10-25 Thread Martin Kreidenweis (Created) (JIRA)
: OFBiz Issue Type: Bug Components: accounting Affects Versions: SVN trunk Reporter: Martin Kreidenweis When we already created an invoice for an order and we want to change the order (e.g. cancel items from the order), we might want to cancel the whole invoice

[jira] [Updated] (OFBIZ-4516) OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice

2011-10-25 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4516: -- Attachment: OFBIZ-4516.patch Patch: resetting amount/quantity in OrderItemBilling

[jira] [Updated] (OFBIZ-4502) Improved CMS tree: more functionality and faster for large trees

2011-10-24 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4502: -- Attachment: CMS-Tree-Improvement.patch the patch Improved CMS tree

[jira] [Created] (OFBIZ-4502) Improved CMS tree: more functionality and faster for large trees

2011-10-24 Thread Martin Kreidenweis (Created) (JIRA)
Components: content Affects Versions: SVN trunk Reporter: Martin Kreidenweis Attachments: CMS-Tree-Improvement.patch We here at [Lusini|http://www.lusini.de/] did several improvements to the CMS backend to make it more useable for large CMS installations

Re: Should loadSalesInvoiceFact be run on return instead of commit?

2011-10-12 Thread Martin Kreidenweis
Hi, I see Leon has discovered a similar issue for a different SECA in Jira 4469, but his patch uses global-commit rather than return. I'm happy to submit a patch, but would Leon's approach be better? I think global-commit is usually the way to go for async services (usually

[jira] [Commented] (OFBIZ-4453) Refactoring JMS Handling

2011-09-29 Thread Martin Kreidenweis (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117143#comment-13117143 ] Martin Kreidenweis commented on OFBIZ-4453: --- I'd like to make two remarks: I

[jira] [Updated] (OFBIZ-4453) Refactoring JMS Handling

2011-09-29 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4453: -- Attachment: JMS-keep-connection.patch We already made some code changes to reuse

Re: findOne signatures refactoring

2011-09-28 Thread Martin Kreidenweis
Hi, changing a method call from ellipsis signature to the other. I introduced UtilMisc.toMap for the last argument because I had 2 values and changed for one only, hence ellipsis could not be used. I did that in a hurry, not thinking about the argument swap. Let me try to explain from

[jira] [Created] (OFBIZ-4451) warning in log when using @renderSubContentCache freemarker macro

2011-09-28 Thread Martin Kreidenweis (Created) (JIRA)
Components: content Affects Versions: SVN trunk Reporter: Martin Kreidenweis Priority: Minor When using the @renderSubContentCache freemarker macro, warnings like this appear in the log: {code} [ GenericEntity.java:314:WARN ] The field name (or key

[jira] [Updated] (OFBIZ-4451) warning in log when using @renderSubContentCache freemarker macro

2011-09-28 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4451: -- Attachment: OFBIZ-4451.patch Patch: GenericValue.get() will actually not throw

[jira] [Created] (OFBIZ-4452) updateContentAndUploadedFile service broken

2011-09-28 Thread Martin Kreidenweis (Created) (JIRA)
updateContentAndUploadedFile service broken --- Key: OFBIZ-4452 URL: https://issues.apache.org/jira/browse/OFBIZ-4452 Project: OFBiz Issue Type: Bug Reporter: Martin Kreidenweis

[jira] [Updated] (OFBIZ-4452) updateContentAndUploadedFile service broken

2011-09-28 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4452: -- Component/s: content Affects Version/s: SVN trunk

[jira] [Updated] (OFBIZ-4452) updateContentAndUploadedFile service broken

2011-09-28 Thread Martin Kreidenweis (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4452: -- Attachment: OFBIZ-4452.patch patch fixes bug in DataServices.createFileMethod

[jira] [Commented] (OFBIZ-4341) GenericDelegator.findOne cache not working for not-found values (cached not-found treated like cache miss)

2011-09-27 Thread Martin Kreidenweis (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115316#comment-13115316 ] Martin Kreidenweis commented on OFBIZ-4341: --- Thanks for checking it out, Dimitri

Re: findOne signatures refactoring

2011-09-27 Thread Martin Kreidenweis
Hi, I suggest to refactor findOne signatures. Or actually only the signature w/out ellipsis. When we introduced the signature with elilpsis the cache argument was inevitably in the middle. We kept the signature for the other method. I was caught recently by changing a method call from

[jira] [Commented] (OFBIZ-4295) Deserialization of arrays with UtilObject.getObject() throws ClassNotFoundException

2011-09-26 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114519#comment-13114519 ] Martin Kreidenweis commented on OFBIZ-4295: --- Just checking up on the ticket

[jira] [Commented] (OFBIZ-4341) GenericDelegator.findOne cache not working for not-found values (cached not-found treated like cache miss)

2011-09-26 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114520#comment-13114520 ] Martin Kreidenweis commented on OFBIZ-4341: --- Just checking up on the ticket

[jira] [Commented] (OFBIZ-4335) Delegator creation fails with new ExecutionPool on trunk

2011-09-26 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114523#comment-13114523 ] Martin Kreidenweis commented on OFBIZ-4335: --- Just checking up on the ticket

[jira] [Commented] (OFBIZ-4341) GenericDelegator.findOne cache not working for not-found values (cached not-found treated like cache miss)

2011-09-26 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114561#comment-13114561 ] Martin Kreidenweis commented on OFBIZ-4341: --- Hi Dimitri, your patch causes

Re: Script to change the old folder structure to the new

2011-08-03 Thread Martin Kreidenweis
Hi, I wrote a script to change the old folder structure to the new in which test and code separated. We probably want to run the script in a SVN checkout and use explicit svn mv commands to correctly track renames in the repo. This is very important for later merges. Also having the file

[jira] [Commented] (OFBIZ-4345) voided payments are auto-applied to new order invoices

2011-08-02 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13076089#comment-13076089 ] Martin Kreidenweis commented on OFBIZ-4345: --- Hi Bilgin, thanks for looking

Re: Using elRTE editor to edit Freemarker templates that include macros

2011-07-21 Thread Martin Kreidenweis
Hi, we finally ended up removing the WYSIWYG altogether because elRTE broke too much of the HTML and Freemarker code we are using. Martin On 20.07.2011 11:09, Chatree Srichart wrote: Hi René Scheibe, How about your patch for the elRTE editor? Could you please commit it if you have time? I

[jira] [Commented] (OFBIZ-4335) Delegator creation fails with new ExecutionPool on trunk

2011-07-21 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068936#comment-13068936 ] Martin Kreidenweis commented on OFBIZ-4335: --- I have an alternate, very simple

[jira] [Created] (OFBIZ-4345) voided payments are auto-applied to new order invoices

2011-07-20 Thread Martin Kreidenweis (JIRA)
: accounting Affects Versions: SVN trunk Reporter: Martin Kreidenweis {{InvoiceServices.createInvoiceForOrder}} automatically creates {{PaymentApplication}} records when unapplied payments exist for the order. Unfortunately this doesn't consider the {{Payment.statusId}}. So when a user

[jira] [Updated] (OFBIZ-4345) voided payments are auto-applied to new order invoices

2011-07-20 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4345: -- Attachment: OFBIZ-4345-voidedAutoApply.patch Patch resolves the issue by not creating

[jira] [Created] (OFBIZ-4341) GenericDelegator.findOne cache not working for not-found values (cached not-found treated like cache miss)

2011-07-16 Thread Martin Kreidenweis (JIRA)
/jira/browse/OFBIZ-4341 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Martin Kreidenweis {{GenericDelegator.findOne}} doesn't handle the cache consistently. When it doesn't find anything, it puts

[jira] [Updated] (OFBIZ-4341) GenericDelegator.findOne cache not working for not-found values (cached not-found treated like cache miss)

2011-07-16 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4341: -- Attachment: OFBIZ-4341-findOne-cache-fix.patch patch fixing the findOne cache issue

[jira] [Created] (OFBIZ-4295) Deserialization of arrays with UtilObject.getObject() throws ClassNotFoundException

2011-05-26 Thread Martin Kreidenweis (JIRA)
: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Martin Kreidenweis Deserialization of arrays with {{UtilObject.getObject()}} throws a {{ClassNotFoundException}}. This happened to us when we enabled the distributed cache clear

[jira] [Updated] (OFBIZ-4295) Deserialization of arrays with UtilObject.getObject() throws ClassNotFoundException

2011-05-26 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4295: -- Attachment: OFBIZ-4295-classloader.patch This patch fixes the array deserialization

[jira] [Created] (OFBIZ-4296) JmsTopicListener started twice when distributed-cache-clear is active

2011-05-26 Thread Martin Kreidenweis (JIRA)
Components: framework Affects Versions: SVN trunk Reporter: Martin Kreidenweis This is a follow up issue of OFBIZ-3987 and OFBIZ-4202. Apparently the problem was not properly fixed. The infinite loop during startup went away, but there still are other side effects

[jira] [Commented] (OFBIZ-4296) JmsTopicListener started twice when distributed-cache-clear is active

2011-05-26 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13039660#comment-13039660 ] Martin Kreidenweis commented on OFBIZ-4296: --- Another thing we noticed when we

[jira] [Created] (OFBIZ-4284) NullPointerException in GenericDelegator during testMode rollback

2011-05-17 Thread Martin Kreidenweis (JIRA)
Components: framework Affects Versions: SVN trunk Reporter: Martin Kreidenweis Test mode rollback doesn't work right in {{GenericDelegator}} for calls to {{removeByPrimary()}} key and {{removeByValue()}} when the row to be deleted didn't exist in the first place. It creates

[jira] [Updated] (OFBIZ-4284) NullPointerException in GenericDelegator during testMode rollback

2011-05-17 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4284: -- Attachment: OFBIZ-4284.patch patch fixing both described issues NullPointerException

Re: Discussion: REST support in OFBiz

2011-05-11 Thread Martin Kreidenweis
Hi, On 10.05.2011 13:07, Adrian Crum wrote: After thinking about this for a while, I came to the conclusion that the REST servlet should have its own request config file. REST request elements will be kept in their own config file and that file will be specified in web.xml. Why reinvent

OrderAdjustment pro-rating in createInvoiceForOrder when using OrderItem.cancelQuantity

2011-03-22 Thread Martin Kreidenweis
Hi, We had a problem with creating invoices for orders with cancelled items. The pro-rating of the order adjustments didn't work as expected. In the createInvoiceForOrder the billingQuantity passed to the service takes into account the cancelQuantity, whereas the quantity from the original

Re: svn commit: r1081912 - /ofbiz/trunk/framework/sql/src/org/ofbiz/sql/Planner.java

2011-03-17 Thread Martin Kreidenweis
Hi Jacques, the 'official' workaround seems to be this: public STMNT extends SQLStatement? SQLPlan? plan(STMNT statement) { This also compiles in older Java versions and doesn't show a warning in Eclipse. Martin On 15.03.2011 20:19, jler...@apache.org wrote: Author: jleroux Date: Tue

Re: svn commit: r1081912 - /ofbiz/trunk/framework/sql/src/org/ofbiz/sql/Planner.java

2011-03-17 Thread Martin Kreidenweis
: Jacques Le Roux jacques.le.r...@les7arts.com Hi Martin, Yes, it compiles just fine in 6.0_22 Why official? I guess you tested it with an older version, which one? Thanks Jacques From: Martin Kreidenweis martin.kreidenw...@tngtech.com Hi Jacques, the 'official' workaround seems

Re: svn commit: r1081093 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/RecurrenceRule.java

2011-03-14 Thread Martin Kreidenweis
Hi, I don't think this change preserves the functionality. Same problem in changeset r1081099. A quick look at the code suggests to me that the case-fallthrough was intended in both files. I suggest reverting those changes, or at lease have them double checked by someone who knows the code.

[jira] Commented: (OFBIZ-4202) Distributed Cache Clear is broken in current versions of OFBiz

2011-02-28 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000301#comment-13000301 ] Martin Kreidenweis commented on OFBIZ-4202: --- Hi, Sascha, I guess you actually

[jira] Created: (OFBIZ-4202) Distributed Cache Clear is broken in current versions of OFBiz

2011-02-25 Thread Martin Kreidenweis (JIRA)
Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Martin Kreidenweis Setting distributed-cache-clear-enabled=true for the delegator in entityengine.xml doesn't work any more: OFBiz goes into an infinite loop during startup. (Only for regular startup

[jira] Created: (OFBIZ-4196) Non-existing image (new image management system) returns 500 error instead of 404

2011-02-22 Thread Martin Kreidenweis (JIRA)
Issue Type: Bug Components: content Affects Versions: SVN trunk Reporter: Martin Kreidenweis The new ImageUrlServlet throws an IndexOutOfBoundsException or NullPointerException when called with invalid paths: https://demo-trunk.ofbiz.apache.org/catalog/images

[jira] Created: (OFBIZ-4176) savePaymentGatewayResponse throws exceptions due to foreign key constraints

2011-02-11 Thread Martin Kreidenweis (JIRA)
Issue Type: Bug Components: accounting Affects Versions: SVN trunk Reporter: Martin Kreidenweis If you use a CC payment service provider that actually wants to save not only PaymentGatewayResponses, but also PaymentGatewayResponseMessages, saving these to the database

[jira] Updated: (OFBIZ-4176) savePaymentGatewayResponse throws exceptions due to foreign key constraints

2011-02-11 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4176: -- Attachment: OFBIZ-4176.patch Fix for the issue: we created a new

[jira] Created: (OFBIZ-4178) New Custom Method order ID generation implementation in OFBIZ-3765 broke backwards compatiblity

2011-02-11 Thread Martin Kreidenweis (JIRA)
Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: SVN trunk Reporter: Martin Kreidenweis Due to missed col-name attributes for the deprecated field names (old* fields) and a typo in the minilang code in the original patch

[jira] Updated: (OFBIZ-4178) New Custom Method order ID generation implementation in OFBIZ-3765 broke backwards compatiblity

2011-02-11 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4178: -- Attachment: OFBIZ-4178.patch fixes order id generation backwards compatiblity New

Re: svn commit: r1056700 - in /ofbiz/trunk/applications/product: config/ProductErrorUiLabels.xml src/org/ofbiz/product/category/CategoryServices.java

2011-02-10 Thread Martin Kreidenweis
not found in the current category.); +return ServiceUtil.returnError(UtilProperties.getMessage(resourceError, +categoryservices.product_not_found, locale)); } MapString, Object result = ServiceUtil.returnSuccess(); -- Martin Kreidenweis

[jira] Updated: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4079: -- Attachment: OFBIZ-4079_cmsEditorFixes.patch fixing some bugs in CMS introduced in svn

[jira] Commented: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980647#action_12980647 ] Martin Kreidenweis commented on OFBIZ-4079: --- I'm not sure my patch fixes all

[jira] Updated: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4079: -- Attachment: OFBIZ-4079_cmsEditorFixes.svn.patch Hi Sascha, I re-created the patch

[jira] Created: (OFBIZ-4107) if-regexp conditions in Minilang and Screens not thread safe

2011-01-11 Thread Martin Kreidenweis (JIRA)
Components: framework Affects Versions: SVN trunk Reporter: Martin Kreidenweis The Perl5Matcher Perl5Compiler are not thread safe, as mentioned in their documentation: http://jakarta.apache.org/oro/api/org/apache/oro/text/regex/Perl5Compiler.html A separate instance should be used per

[jira] Updated: (OFBIZ-4107) if-regexp conditions in Minilang and Screens not thread safe

2011-01-11 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4107: -- Attachment: OFBIZ-4107-partial-fix.patch OFBIZ-4107-test.patch Test

Re: [jira] Closed: (OFBIZ-4104) add taxPercentage and taxTotal member variables to ShoppingCartItem to ease tax calculation and display

2011-01-11 Thread Martin Kreidenweis
Hi, But please in the future provide patches with no absolute pathes. Your patch did not apply until I removed the a/ and b/... What tool are you applying the patch with? If you're using patch, just do a patch -p1 x.patch instead of patch -p0 x.patch and it will work. Martin

[jira] Created: (OFBIZ-4108) Links to Path Alias and Meta Tags in CMS don't work any more

2011-01-11 Thread Martin Kreidenweis (JIRA)
Components: content Affects Versions: SVN trunk Reporter: Martin Kreidenweis * Go to https://demo-trunk.ofbiz.apache.org/content/control/WebSiteCms?webSiteId=WebStore * Select some content, e.g. Store Policies * Try to click the Path Alias or Meta Tags links at the top

[jira] Updated: (OFBIZ-4108) Links to Path Alias and Meta Tags in CMS don't work any more

2011-01-11 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-4108: -- Attachment: OFBIZ-4108_CMS_link_fix.patch patch removes calls to non-existing

[jira] Created: (OFBIZ-3910) Sending multiple emails simultaneously to new party does not work properly

2010-08-30 Thread Martin Kreidenweis (JIRA)
Type: Bug Components: party Affects Versions: Release Branch 10.04 Reporter: Martin Kreidenweis Sending more than one email at once to a party that never has received an email using the sendMailFromScreen service fails. Creating the communication event for the email

[jira] Created: (OFBIZ-3883) Customer's Shipment Address Not Assigned to Dropship Purchase Orders

2010-08-06 Thread Martin Kreidenweis (JIRA)
Components: order Affects Versions: Release Branch 10.04, SVN trunk Environment: demo-trunk.ofbiz.apache.org Reporter: Martin Kreidenweis When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so

[jira] Commented: (OFBIZ-1151) Passwords are not seeded

2010-08-04 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12895313#action_12895313 ] Martin Kreidenweis commented on OFBIZ-1151: --- Adam, great news about the patch

[jira] Created: (OFBIZ-3847) Entity ECAs not triggered correctly when using Delegator.storeAll() method

2010-07-05 Thread Martin Kreidenweis (JIRA)
Type: Bug Components: framework Affects Versions: Release Branch 10.04 Reporter: Martin Kreidenweis The conditions don't work when updating (not creating) entities using the Delegator.storeAll() method. E.g. the following condition does not work: {code} eca entity

[jira] Updated: (OFBIZ-3847) Entity ECAs not triggered correctly when using Delegator.storeAll() method

2010-07-05 Thread Martin Kreidenweis (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kreidenweis updated OFBIZ-3847: -- Attachment: GenericDelegator.java.diff This should fix the issue in GenericDelegator