Weird, I don't get it as you can check at
https://issues.apache.org/jira/secure/attachment/12994793/OFBIZ-9352-not-used.png
Jacques
Le 27/02/2020 à 15:03, Michael Brohl a écrit :
Jacques,
I know and used this feature on demo-trunk. If you select the AccountingUiLabels.xml and search for unuse
Saying is not proving IMO.
The contributor should at least provide information *how* he did the
checks along with the patch to help the committer decide. That is very
reasonable to ask for.
Low hanging fruits can also be foul. It does not help anyone to commit a
patch to remove labels and ge
Jacques,
I know and used this feature on demo-trunk. If you select the
AccountingUiLabels.xml and search for unused labels, you get
AccountingDeleteRateAmount among others.
Using a find for *all* files with the unused labels checkbox did not
display any results for me.
Did not dig further
Michael,
Inline,
Le 27/02/2020 à 13:35, Michael Brohl a écrit :
You simply cannot rely on the LabelManager itself. It shows unused labels which
are used [1].
Example: AccountingErrorUiLabels.xml#AccountingDeleteRateAmount is shown as
unused on demo-trunk but is used in RateServices.groovy.
Re: IMO this check cannot be burdened upon the committer (if another
contributor provided the patch).The responsibility to thoroughly check if a
removed label is in fact unused should be on the contributor. Which means
he should prove which steps he took to check each removed label [2].
We can all
Whatever the participation and the outcome of this discussion will be...
In the past complaints (relating to the subject of labels) have been raised
about:
- patches too big (because of too much work to investigate, merges
leading to conflicts in local repos), and
- patches too small (as
Given that the OFBiz community consists of more than just a handful of
active PMC Members, Committers and other contributors, the question should
*not* just be: Should we clean labels'.
But rather: Should we welcome contributions that only address the cleaning
of unused labels, and if so get them
You simply cannot rely on the LabelManager itself. It shows unused
labels which are used [1].
Example: AccountingErrorUiLabels.xml#AccountingDeleteRateAmount is shown
as unused on demo-trunk but is used in RateServices.groovy.
So steps 1 and 2 are necessary because changes should not introduc
Hi,
With OFBIZ-9352 (under OFBIZ-10565) Pierre Smits propose to remove unused
labels from AccountingUiLabels.xml
This morning I looked at the related PR (17) and, using Label Manager (in Webtools) found that there are much more unused labels than those Pierre
proposes to remove.
I checked th
