[ https://issues.apache.org/jira/browse/OFBIZ-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670362#comment-13670362 ]
Jacques Le Roux edited comment on OFBIZ-5201 at 5/30/13 2:13 PM: ----------------------------------------------------------------- Thanks Parimal, Ankit for testing and Arpit Singh Pandya for comment. Parimal, your slightly modified patch is in trunk r1487854 R12.04 r1487860 R11.04 r1487866 R10.04 r1487867 I simply added in label that no productId entered would return all the orders, also in French was (Author: jacques.le.roux): Thanks Parimal, Ankit for testing, Parimal, your slightly modified patch is in trunk r1487854 R12.04 r1487860 R11.04 r1487866 R10.04 r1487867 I simply added in label that no productId entered would return all the orders, also in French > Find Order functions - Not working when junk values entered for product Id > -------------------------------------------------------------------------- > > Key: OFBIZ-5201 > URL: https://issues.apache.org/jira/browse/OFBIZ-5201 > Project: OFBiz > Issue Type: Bug > Components: order > Reporter: Parimal Gain > Assignee: Jacques Le Roux > Priority: Minor > Labels: order > Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, > Release Branch 12.04 > > Attachments: OFBIZ-5201.patch > > > Problem specification and step - > 1) Go to Order Manager app > Find Orders > 2) Enter valid product id for which order exists > 3) Relevant orders with entered product value would be shown in search results > 4) Enter invalid product id - JUNK value > 5) Error behvaior:All orders on the system would be highlighted > 6) Actual behavior: No order should be shown as search results, as no order > exists with this JUNK product id on system > Observation - > When looked into code level found that system apply check for two condition - > 1) If passes productId starts or ends with % or * then add that in condition > list as it is and it returns all order that contains the word for product Ids. > 2) If the above condition is failed the check if the product corresponding to > product id is present or not. > 3) If exists then check for variants (if its virtual)all this. > 4) If product not exists then the action is missing i.e. no condition is > added and it returns all order available. > Recommendation - > There are two ways to solve the issue - > 1) If product corresponding to passes productId is not present then return > message to user that order is not present. > 2) If the thought process for current behavior is show all record if product > not available then user should get a message as well that "Order is not > available for your search product but we have all these order in system" to > convey the correct message to user. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira