[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126864#comment-14126864 ] Jacopo Cappellato commented on OFBIZ-5761: -- This is a large patch and it will tak

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126966#comment-14126966 ] Jacques Le Roux commented on OFBIZ-5761: Thanks for your review. This is indeed no

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127078#comment-14127078 ] Jacopo Cappellato commented on OFBIZ-5761: -- Jacques wrote: {quote}Please review,

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127106#comment-14127106 ] Jacques Le Roux commented on OFBIZ-5761: This code is already used for more than a

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127114#comment-14127114 ] Jacopo Cappellato commented on OFBIZ-5761: -- As it was mentioned a number of times

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127124#comment-14127124 ] Jacques Le Roux commented on OFBIZ-5761: I totally agree, as I said I will wait fe

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130655#comment-14130655 ] Jacques Le Roux commented on OFBIZ-5761: Mmm, some time ago I noticed something I

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132133#comment-14132133 ] Nicolas Malin commented on OFBIZ-5761: -- Jacques, I will look it this next week. I ag

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136430#comment-14136430 ] Nicolas Malin commented on OFBIZ-5761: -- Jacques, I have checked the code and ... it h

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139541#comment-14139541 ] Jacques Le Roux commented on OFBIZ-5761: NIcolas, here is another necessary change

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143881#comment-14143881 ] Jacques Le Roux commented on OFBIZ-5761: Hi Nicolas, did you get a chance to look

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143888#comment-14143888 ] Jacques Le Roux commented on OFBIZ-5761: Ha, I wrote this comment this mornig. Sin

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157144#comment-14157144 ] Jacques Le Roux commented on OFBIZ-5761: Hi Nicolas, I'm not sure to understand wh

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172487#comment-14172487 ] Jacques Le Roux commented on OFBIZ-5761: Just as a note here for now. In my custom

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226106#comment-14226106 ] Jacques Le Roux commented on OFBIZ-5761: Ha I wondered a second what was IHM, it's

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234268#comment-14234268 ] Jacques Le Roux commented on OFBIZ-5761: I have a small bug fix but I can't commit

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235204#comment-14235204 ] Jacques Le Roux commented on OFBIZ-5761: This bug is fixed at revision: 1643172. I

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235496#comment-14235496 ] Nicolas Malin commented on OFBIZ-5761: -- Ok thanks Jacques for this issues, and the im

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235700#comment-14235700 ] Jacques Le Roux commented on OFBIZ-5761: While working on OFBIZ-5430, I fixed a la

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035808#comment-15035808 ] K Sharad Bhushan commented on OFBIZ-5761: - What is noticed in this change is : "de

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036052#comment-15036052 ] Jacques Le Roux commented on OFBIZ-5761: Which change are you talking about? I can

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036237#comment-15036237 ] K Sharad Bhushan commented on OFBIZ-5761: - Sorry forgot to mention the version and

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036387#comment-15036387 ] Jacques Le Roux commented on OFBIZ-5761: Sorry I still don't get it. I find no men

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037024#comment-15037024 ] K Sharad Bhushan commented on OFBIZ-5761: - You are checking it in diff mode, where

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037482#comment-15037482 ] Jacques Le Roux commented on OFBIZ-5761: Thanks, I see your point now! It seems to

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037578#comment-15037578 ] K Sharad Bhushan commented on OFBIZ-5761: - Yes, that is one of the context. We sho

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037588#comment-15037588 ] Pierre Smits commented on OFBIZ-5761: - It is logical to delete the ShipGroup associati

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037624#comment-15037624 ] K Sharad Bhushan commented on OFBIZ-5761: - Hi Pierre, Can i know the logic - it h

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037654#comment-15037654 ] Pierre Smits commented on OFBIZ-5761: - Hi, The logic is this: Order items are explic

[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

[ https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037667#comment-15037667 ] K Sharad Bhushan commented on OFBIZ-5761: - OK. But cancelOrderItem does not remove