[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-05-19 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14549868#comment-14549868 ] Jacques Le Roux commented on OFBIZ-6291: Smart move, thanks Adrian! Update code

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-05-19 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550023#comment-14550023 ] Gareth Carter commented on OFBIZ-6291: -- Thanks Adrian. Update code to check for

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-24 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510663#comment-14510663 ] Gareth Carter commented on OFBIZ-6291: -- What I have found is the cast to BigDecimal

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-24 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510685#comment-14510685 ] Adrian Crum commented on OFBIZ-6291: Mini-language is a scripting language. One of the

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-24 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510829#comment-14510829 ] Gareth Carter commented on OFBIZ-6291: -- What about comparing 2.001 and 2.0001? Lets

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509298#comment-14509298 ] Gareth Carter commented on OFBIZ-6291: -- int i = foo.compareTo(baz); return i = 0;

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509305#comment-14509305 ] Adam Heath commented on OFBIZ-6291: --- int i = foo... isn't the part that is slower. The

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509267#comment-14509267 ] Adam Heath commented on OFBIZ-6291: --- * The patch introduces new blank lines; that should

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508680#comment-14508680 ] Adrian Crum commented on OFBIZ-6291: As the code comment states, the current

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508686#comment-14508686 ] Gareth Carter commented on OFBIZ-6291: -- Just realised minilang_compare.patch does not