[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238973#comment-15238973
]
Gareth Carter commented on OFBIZ-6705:
--
Yes, we should change it for consistency
> some files set
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238792#comment-15238792
]
Gareth Carter commented on OFBIZ-6705:
--
Sorry Jacques but this Jira hasn't actually been fixed, the
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235078#comment-15235078
]
Jacques Le Roux commented on OFBIZ-6705:
Only the trunk and the R15.12 branch release need Java 8
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235067#comment-15235067
]
Gareth Carter commented on OFBIZ-6705:
--
His views are reasonable and we were in a similar scenario
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235036#comment-15235036
]
Jacques Le Roux commented on OFBIZ-6705:
>From [our last
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234863#comment-15234863
]
Gareth Carter commented on OFBIZ-6705:
--
Thanks for reviewing, please provide any suggestions.
Are
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232391#comment-15232391
]
Jacques Le Roux commented on OFBIZ-6705:
Totally agreed, thanks Nicolas!
> some files set
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232372#comment-15232372
]
Nicolas Malin commented on OFBIZ-6705:
--
Nice feature.
I didn't analyse all the code but the few as
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228133#comment-15228133
]
Pierre Smits commented on OFBIZ-6705:
-
javadoc extension help in the review process. ;)
> some files
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228125#comment-15228125
]
Gareth Carter commented on OFBIZ-6705:
--
Yes I can add javadoc, I initially didn't add so the
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228114#comment-15228114
]
Pierre Smits commented on OFBIZ-6705:
-
Nice piece of work, [~gareth.carter], but couldn't it do with
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226142#comment-15226142
]
Gareth Carter commented on OFBIZ-6705:
--
I will provide a patch of what we have done internally
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226077#comment-15226077
]
Pierre Smits commented on OFBIZ-6705:
-
So, what do you propose as a solution?
> some files set
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226050#comment-15226050
]
Gareth Carter commented on OFBIZ-6705:
--
Its been a few months that anyone has posted on this jira, I
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984994#comment-14984994
]
Gareth Carter commented on OFBIZ-6705:
--
I only noticed this because we have a custom service
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985131#comment-14985131
]
Gareth Carter commented on OFBIZ-6705:
--
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984003#comment-14984003
]
Jacques Le Roux commented on OFBIZ-6705:
Hi Gareth, did you do more investigatons (code review for
17 matches
Mail list logo