[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-07 Thread Anurag Chandak (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319993#comment-15319993 ] Anurag Chandak commented on OFBIZ-7147: --- Thanks [~jacques.le.roux] and [~arunpati]. > Remove

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-07 Thread Arun Patidar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318545#comment-15318545 ] Arun Patidar commented on OFBIZ-7147: - Thanks [~jacques.le.roux]. > Remove parentTypeId from

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317240#comment-15317240 ] Jacques Le Roux commented on OFBIZ-7147: PLease Arun use short refs for Jira issues, easier to

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-06 Thread Arun Patidar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316487#comment-15316487 ] Arun Patidar commented on OFBIZ-7147: - Created a new ticket

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-03 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314187#comment-15314187 ] Jacques Le Roux commented on OFBIZ-7147: But we still need to fix the

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313625#comment-15313625 ] Jacques Le Roux commented on OFBIZ-7147: As I said in dev ML there is still a test issue but only

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313622#comment-15313622 ] Jacques Le Roux commented on OFBIZ-7147: Backported in R13.07 at r1746459 > Remove parentTypeId

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-02 Thread Anurag Chandak (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312051#comment-15312051 ] Anurag Chandak commented on OFBIZ-7147: --- Hi [~arunpati], Due to data changes "Find AP Invoices" and

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Arun Patidar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311773#comment-15311773 ] Arun Patidar commented on OFBIZ-7147: - I have committed patch attached on ticket OFBIZ-7124 at rev:

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Arun Patidar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311731#comment-15311731 ] Arun Patidar commented on OFBIZ-7147: - Hi [~jacques.le.roux] This should fix with the patch attached

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310878#comment-15310878 ] Jacques Le Roux commented on OFBIZ-7147: All the tests fail because of bq. The following required

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310691#comment-15310691 ] Jacques Le Roux commented on OFBIZ-7147: Reverting r1746459 and applying Anurag's patch does not

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Arun Patidar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310158#comment-15310158 ] Arun Patidar commented on OFBIZ-7147: - Thanks Jacques for details and suggestion. This makes perfect

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310129#comment-15310129 ] Jacques Le Roux commented on OFBIZ-7147: I guess in some cases it could be useful, that's why I

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310127#comment-15310127 ] Jacques Le Roux commented on OFBIZ-7147: I got it, I was suggesting this {code} Index:

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Arun Patidar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310104#comment-15310104 ] Arun Patidar commented on OFBIZ-7147: - Hi [~jacques.le.roux] Yes, this is logical and also useful to

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310056#comment-15310056 ] Jacques Le Roux commented on OFBIZ-7147: Previously there was indeed no parent, but what not an

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309928#comment-15309928 ] Deepak Dixit commented on OFBIZ-7147: - This has been introduced in r#532739, It seems its mistakenly

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-06-01 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309905#comment-15309905 ] Ashish Vijaywargiya commented on OFBIZ-7147: It is human made mistake so yes we should go

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-05-31 Thread Arun Patidar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309313#comment-15309313 ] Arun Patidar commented on OFBIZ-7147: - Hi [~pfm.smits], Here, my suggestion is to fix the data only,

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-05-31 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307988#comment-15307988 ] Pierre Smits commented on OFBIZ-7147: - That is not good. How do you suggest to fix this? > Remove