[
https://issues.apache.org/jira/browse/OFBIZ-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225033#comment-13225033
]
Adrian Crum edited comment on OFBIZ-4300 at 3/8/12 6:29 AM:
------------------------------------------------------------
The hard coded DOCTYPE was necessary because of the screen widget boundary
comments. The DOCTYPE element needs to be emitted before passing control to the
screen widgets, otherwise you will have widget boundary comments appear before
the DOCTYPE element - which causes problems with some browsers.
Changing the hard-coded DOCTYPE text to a property would be fine, but we still
need to write the DOCTYPE element before passing control to the screen widgets.
was (Author: adri...@hlmksw.com):
The hard coded DOCTYPE was necessary because of the screen widget boundary
comments. The DOCTYPE element needs to be emitted before passing control to the
screen widgets, otherwise you will have widget boundary comments appear before
the DOCTYPE element - which causes problems with some browsers.
Changing the hard-coded DOCTYPE text to a property would be fine, but we still
need to write the DOCTYPE before passing control to the screen widgets.
> Make doctype as a configuration
> -------------------------------
>
> Key: OFBIZ-4300
> URL: https://issues.apache.org/jira/browse/OFBIZ-4300
> Project: OFBiz
> Issue Type: Sub-task
> Reporter: Patrick Antivackis
> Priority: Minor
>
> Today doctype is either generated by java (hard coded) or ftl macros.
> The idea is :
> - to externalize doctypes to a config file
> (framework/base/config/doctype.properties)
> - define a default doctype in the previous config file for all ofbiz
> application
> - allow a specific doctype at an application level (web.xml)
> - allow a specific doctype at a view level (controller.xml)
> I imagine the config file like this :
> {code:title=/framework/base/config/doctype.properties|borderStyle=solid}
> ####
> # OFBiz Doctype properties File
> ####
> w3c.html-4.01-strict=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
> "http://www.w3.org/TR/html4/strict.dtd";>
> w3c.html-4.01-transitional=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01
> Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd";>
> w3c.html-4.01-frameset=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01
> Frameset//EN" "http://www.w3.org/TR/html4/frameset.dtd";>
> w3c.xhtml-1.0-transitional=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0
> Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
> w3c.xhtml-1.0-strict=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> w3c.xhtml-1.0-frameset=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0
> Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd";>
> w3c.xhtml-1.1=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
> "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd";>
> w3c.html5=<!DOCTYPE HTML>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
