[ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David E. Jones closed OFBIZ-2172. --------------------------------- Resolution: Fixed Thanks Bruno, this looks like a good foundation (ie data model, etc looks good; even the seed data in ecommerce looks good given the definition that seed data is maintained with code so works well with the ecommerce templates). I added some comments in the commit log about things that are not yet done... correct me if I missed something that is actually done though! It is in SVN rev 743202. Here's the commit log for convenience: "Applied patch from Bruno Busco in Jira #OFBIZ-2172 with basics for VisualThemeSet; still not possible to change themes in ecommerce (should probably be supported on the back end instead of the front end, ie in the catalog manager and not by a customer in ecommerce, or perhaps only allowed in ecommerce if a flag on the ProductStore says its okay; also does not yet filter selectable themes in the back-end/manager applications" > Web Application / VisualTheme association > ----------------------------------------- > > Key: OFBIZ-2172 > URL: https://issues.apache.org/jira/browse/OFBIZ-2172 > Project: OFBiz > Issue Type: New Feature > Reporter: Bruno Busco > Assignee: Bruno Busco > Fix For: Release Branch 9.3 > > Attachments: VisualThemeSets.patch > > > Following a recent discussion on the ML about an association model between > WebApps and VisualThemes I would like to submit this "half baked" ;-) patch. > Along with any comments you will do on the patch I think now I need some hint > to go further: > 1) In order to have this model working we should have on every application's > WEB.XML file something like this: > <context-param> > <param-name>webSiteId</param-name> > <param-value>CONTENT_SITE</param-value> > <description>A unique ID used to look up the Content entity that serves > as the root for publish points</description> > </context-param> > with a specific different param-name for every webapp. Is this correct? > If yes could we use the same webapp name for the webSiteId? > 2) We should create a WebSite for every WebApp. Is this correct? > 3) I have implemented a filter on the VisualTheme Lookup that let the user > choose among all the applicable themes. (if a WebSiteId is defined) > But doing this I realized that the user could choose a different theme for > different applications and so these should be recorded as preferences. I mean > we should record that a user has selected a theme _for a certain > application_. is this correct? > Thank you for supporting me. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.