[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-16 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756055#action_12756055 ] Jacques Le Roux commented on OFBIZ-2916: Don't worry, It was just because you advic

[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-16 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756022#action_12756022 ] Scott Gray commented on OFBIZ-2916: --- That's a bit worrying considering the only review I

[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-16 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756017#action_12756017 ] Jacques Le Roux commented on OFBIZ-2916: Hi Scott, I tried :D You did most of the

[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753067#action_12753067 ] Jacques Le Roux commented on OFBIZ-2916: Nicolas, It's ok for me as long as both w

[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753047#action_12753047 ] nicolas malin commented on OFBIZ-2916: -- Scott, Jacques, I propose to adapt the patch

[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753020#action_12753020 ] Scott Gray commented on OFBIZ-2916: --- I think the reasoning for the extra attribute was so

[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753016#action_12753016 ] Jacques Le Roux commented on OFBIZ-2916: Nicolas, I think it's a good way of doing

[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753007#action_12753007 ] nicolas malin commented on OFBIZ-2916: -- Hi scott, when I finalize my patch and add in

[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753001#action_12753001 ] Scott Gray commented on OFBIZ-2916: --- Hi Nicolas I haven't reviewed your patch but it sou