Re: [ofbiz-framework] branch release17.12 updated: Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)

2019-11-28 Thread Jacques Le Roux
Hi Mathieu, Samuel, It was late, actually if I refer to http://www.apache.org/dev/committers.html#applying-patches you are actually right Mathieu. Even an ICLA is not needed if Samuel openly contributed a patch[1]. Through Jira is preferred, I guess it was done that way. Of course, if not

Re: [ofbiz-framework] branch release17.12 updated: Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)

2019-11-27 Thread Mathieu Lirzin
Hello Jacques, Jacques Le Roux writes: > Not a big deal (it's only in the commits log), I'm not sure we want stuff > like: > > Le 27/11/2019 à 17:48, m...@apache.org a écrit : >> Author: Samuel Trégouët > > Normally we rather use something like > >Thanks to Samuel Tregouet for this fix > >

Re: [ofbiz-framework] branch release17.12 updated: Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)

2019-11-27 Thread Jacques Le Roux
Hi Mathieu, All, Not a big deal (it's only in the commits log), I'm not sure we want stuff like: Le 27/11/2019 à 17:48, m...@apache.org a écrit : Author: Samuel Trégouët Normally we rather use something like Thanks to Samuel Tregouet for this fix I did not notice yet, we have already 10