Re: Accessibility scope of variables in Java packages and modules

Hello Yash, Inline ... On Wed, May 2, 2018, 8:59 AM Yash Sharma wrote: > Hello Taher, > > Yes certainly you cleared my doubts, and Yes I am confirming your point > with the feedback. > > What I get after this entire discussion is, I was concentrating on >

Re: Accessibility scope of variables in Java packages and modules

Hello Taher, Yes certainly you cleared my doubts, and Yes I am confirming your point with the feedback. What I get after this entire discussion is, I was concentrating on Refactoring and you are emphasizing on Re-Engineering (it will not be an OFBiz Update with new tricks it will be an OFBiz

Re: Accessibility scope of variables in Java packages and modules

Hello Yash, So you are proving my point with your feedback. What do I mean by that? You are focusing on things like the below and then you are submitting a patch accordingly. - use lambda expressions - Type inference - Using quotes - whatever else pattern you seek My recommendation instead is

Re: Accessibility scope of variables in Java packages and modules

* I am not pen downing things, but yea I am really full on high energy to work on these front. Thanks & Regards, -- *Pradhan Yash Sharma* On Mon, Apr 30, 2018 at 11:37 AM, Yash Sharma wrote: > Hello, > > Thank you for the response, I was wondering about the

Re: Accessibility scope of variables in Java packages and modules

Hello, Thank you for the response, I was wondering about the volume of refactoring we can do at each component, so let's apply Divide and Conquer approach for each component upgrading work. I can see a few patterns for the update which I've listed down in my previous mail. We can pick any piece

Re: Accessibility scope of variables in Java packages and modules

Hello Yash, Thank you for your work on this so far. It's great to see people focusing on refactoring, which I think should probably be the top priority for all of us. I will review the JIRAs some more over the coming days, but I have a concern that some of the patches are very large. We had

Re: Accessibility scope of variables in Java packages and modules

Hi Devs, Here is the detailed information about the things I am working on for performance optimization in our OFBiz code. *1.) Downsize Accessibility Scope* I've tried to downsize accessibility scope of classes, interfaces, abstract class, declared member variables, enumerations, methods, and

Re: Accessibility scope of variables in Java packages and modules

Thank you for the feedback I've created a Jira ticket OFBIZ-10343 and I will add patches for the same for your review. Thanks & Regards, -- *Pradhan Yash Sharma* On Fri, Apr 13, 2018 at 5:50 PM, Taher Alkhateeb

Re: Accessibility scope of variables in Java packages and modules

Hello Pradhan, Refactoring is exactly what we need and is a welcomed activity. I think we should, however, try to avoid "big ideas" across the entire code base. The subject of your message is the reason why I say that. So, if you want to start refactoring, I suggest to start with one piece of

Re: Accessibility scope of variables in Java packages and modules

Hi, Please avoid ThreadLocal as much as possible For the rest I think a Jira with a patch fits (means sounds OK with me at 1st glance) Jacques Le 13/04/2018 à 11:14, Pradhan Yash Sharma a écrit : Hello, While I was working on UtilCache.java file came across some improvements, they are as

Accessibility scope of variables in Java packages and modules

Hello, While I was working on UtilCache.java file came across some improvements, they are as follows: 1) Method and Variable access modifiers can be narrowed down to private access modifier. 2) Then AtomicLong can be given value 0L instead of 0. 3) Some Variables is used in both synchronized