Re: Adding more flexibility for the definition of entity-data-readers

2009-02-01 Thread Jacopo Cappellato
Implemented in rev. 739782 Jacopo On Jan 31, 2009, at 7:41 PM, David E Jones wrote: If you haven't done so already then yeah, that would be the way to go (ie a new/different constructor). -David On Jan 31, 2009, at 1:50 AM, Jacopo Cappellato wrote: This is a good idea... I had a look a

Re: Adding more flexibility for the definition of entity-data-readers

2009-01-31 Thread David E Jones
If you haven't done so already then yeah, that would be the way to go (ie a new/different constructor). -David On Jan 31, 2009, at 1:50 AM, Jacopo Cappellato wrote: This is a good idea... I had a look at the code (EntityDataReaderInfo that extends ResourceInfo that extends NamedInfo) b

Re: Adding more flexibility for the definition of entity-data-readers

2009-01-31 Thread Jacopo Cappellato
This is a good idea... I had a look at the code (EntityDataReaderInfo that extends ResourceInfo that extends NamedInfo) but I couldn't find an easy way to get an instance of a EntityDataReaderInfo without an org.w3c.dom.Element. Should I simply add a new constructor that accepts a string (t

Re: Adding more flexibility for the definition of entity-data-readers

2009-01-30 Thread David E Jones
This sounds fine. Why is the "default" reader needed? Couldn't we just add readers on the fly if referenced in ofbiz-component.xml files just like if they were specified in the entityengine.xml file? I guess the only downside to this would be that if someone was trying to use an existing

Adding more flexibility for the definition of entity-data-readers

2009-01-30 Thread Jacopo Cappellato
Hi all, I have a proposal and a question about entity-data-readers (seed, seed- initial, demo, ext, ext-test, ext-demo). *Question* what is the meaning of specifying the readers in the datasource element? Is it not enough to define them and then just use them in the ofbiz-component files?