Re: Controller Injection

2010-05-03 Thread Scott Gray
On 4/05/2010, at 8:02 AM, Bruno Busco wrote: > Hi Scott, > > 2010/5/3 Scott Gray > >> Hi Bruno, >> >> Thanks for taking a look, here's a couple of points about your suggestions: >> - You can't mix and match attributes like that on a single element, you'd >> need to have a separate element for

Re: Controller Injection

2010-05-03 Thread Bruno Busco
Hi Scott, 2010/5/3 Scott Gray > Hi Bruno, > > Thanks for taking a look, here's a couple of points about your suggestions: > - You can't mix and match attributes like that on a single element, you'd > need to have a separate element for each attribute set. > OK, I see what you mean. > - I real

Re: Controller Injection

2010-05-03 Thread Scott Gray
Hi Bruno, Thanks for taking a look, here's a couple of points about your suggestions: - You can't mix and match attributes like that on a single element, you'd need to have a separate element for each attribute set. - I really wanted to avoid putting too much definition in the component file its

Re: Controller Injection

2010-05-03 Thread Bruno Busco
Hi Scott, could we consider to use the ofbiz-component.xml file to contain all the injections like follows? http://www.w3.org/2001/XMLSchema-instance"; xsi:noNamespaceSchemaLocation=" http://ofbiz.apache.org/dtds/ofbiz-component.xsd";> We would need only one new tag with type=(

Re: Controller Injection

2010-05-03 Thread Scott Gray
Okay for the naming, how about we add a wrapping element that would contain all of our "plug-in" information: (we could replace inject with plug-ins or something) That would nicely group all plug-in information in one spot. Another option for the *-widget and uiLabels

Re: Controller Injection

2010-05-02 Thread Scott Gray
On 3/05/2010, at 11:41 AM, Bob Morley wrote: > Bruno Busco wrote: >> >> 2010/5/2 Scott Gray >> >>> To me extend seems clear but I agree it does conflict with the way that >>> term is used elsewhere in the framework. I don't really like merge >>> though, >>> it doesn't feel like an accurate des

Re: Controller Injection

2010-05-02 Thread Bob Morley
uot;extend" was the right term ... I wonder if this is really just external modification to a controller. Terms that felt kinda close were stuff like application, external-definition, enhance ... perhaps something in that ballpark could be used to define exactly what is happening he

Re: Controller Injection

2010-05-02 Thread Bruno Busco
2010/5/2 Scott Gray > To me extend seems clear but I agree it does conflict with the way that > term is used elsewhere in the framework. I don't really like merge though, > it doesn't feel like an accurate description of what is happening. Any > other ideas anyone? > What about "overrides" ?

Re: Controller Injection

2010-05-02 Thread Scott Gray
To me extend seems clear but I agree it does conflict with the way that term is used elsewhere in the framework. I don't really like merge though, it doesn't feel like an accurate description of what is happening. Any other ideas anyone? Either way, I'd document the xsd so no one will be confu

Re: Controller Injection

2010-05-01 Thread Bruno Busco
What I remembered to have discussed about is actually here: https://issues.apache.org/jira/browse/OFBIZ-3373 -Bruno 2010/5/2 David E Jones > > Just read this... I guess Bruno is thinking along the same lines. > > -David > > > On May 2, 2010, at 12:04 AM, Bruno Busco wrote: > > > Thank you Scott

Re: Controller Injection

2010-05-01 Thread David E Jones
This would allow you to add controller entries to existing apps, but how would you handle other parts that need UI extensions, like menu items and such? -David On May 1, 2010, at 8:03 PM, Scott Gray wrote: > On 1/05/2010, at 12:35 AM, Scott Gray wrote: > >> On 30/04/2010, at 1:49 PM, Scott G

Re: Controller Injection

2010-05-01 Thread David E Jones
Just read this... I guess Bruno is thinking along the same lines. -David On May 2, 2010, at 12:04 AM, Bruno Busco wrote: > Thank you Scott for working on this feature. > "plug-in" type extensions will help a lot. > > I agree with you, I prefer the latter solution also. > It simply overrides t

Re: Controller Injection

2010-05-01 Thread Bruno Busco
Thank you Scott for working on this feature. "plug-in" type extensions will help a lot. I agree with you, I prefer the latter solution also. It simply overrides the entries in a single file with the ones contentained in a new one. Crystal clear. Wouldn't it be better to use the "merge" term inste

Re: Controller Injection

2010-05-01 Thread Scott Gray
On 1/05/2010, at 12:35 AM, Scott Gray wrote: > On 30/04/2010, at 1:49 PM, Scott Gray wrote: > >> What about adding something like the following to ofbiz-component.xml schema >> > include-controller="path/to/controller.xml" >> /> > > Finding the webapp to extend doesn't look so easy, it looks l

Re: Controller Injection

2010-04-30 Thread Scott Gray
On 1/05/2010, at 3:56 AM, Adam Heath wrote: > Scott Gray wrote: >> On 30/04/2010, at 1:49 PM, Scott Gray wrote: >> >>> What about adding something like the following to ofbiz-component.xml schema >>> >> include-controller="path/to/controller.xml" >>> /> >> >> Finding the webapp to extend doesn

Re: Controller Injection

2010-04-30 Thread Adam Heath
Scott Gray wrote: > On 30/04/2010, at 1:49 PM, Scott Gray wrote: > >> What about adding something like the following to ofbiz-component.xml schema >> >include-controller="path/to/controller.xml" >> /> > > Finding the webapp to extend doesn't look so easy, it looks like it would > need to be

Re: Controller Injection

2010-04-30 Thread Scott Gray
On 30/04/2010, at 1:49 PM, Scott Gray wrote: > What about adding something like the following to ofbiz-component.xml schema > include-controller="path/to/controller.xml" > /> Finding the webapp to extend doesn't look so easy, it looks like it would need to be something like: That would be t

Re: Controller Injection

2010-04-30 Thread Scott Gray
On 30/04/2010, at 5:07 PM, David E Jones wrote: > On Apr 29, 2010, at 10:12 PM, Bob Morley wrote: >> >> >> Scott Gray-2 wrote: >>> >>> What about adding something like the following to ofbiz-component.xml >>> schema >>> >> include-controller="path/to/controller.xml" >>> /> >>> >>> This would

Re: Controller Injection

2010-04-30 Thread Scott Gray
On 30/04/2010, at 4:12 PM, Bob Morley wrote: > > > Scott Gray-2 wrote: >> >> What about adding something like the following to ofbiz-component.xml >> schema >> >include-controller="path/to/controller.xml" >> /> >> >> This would basically be similar to the "include" element available in the

Re: Controller Injection

2010-04-29 Thread David E Jones
On Apr 29, 2010, at 10:12 PM, Bob Morley wrote: > > > Scott Gray-2 wrote: >> >> What about adding something like the following to ofbiz-component.xml >> schema >> >include-controller="path/to/controller.xml" >> /> >> >> This would basically be similar to the "include" element available in

Re: Controller Injection

2010-04-29 Thread Bob Morley
e. > I really like the concept. Building on this, two variances for your consideration came to mind ... ... [standard request & view maps elements] http://ofbiz.135035.n4.nabble.com/Controller-Injection-tp2076418p2076487.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Controller Injection

2010-04-29 Thread Scott Gray
What about adding something like the following to ofbiz-component.xml schema This would basically be similar to the "include" element available in the controller schema except that it would override any elements in the web-app's normal controller. Doing this would allow us to externally overri