Re: Discussion: FlexibleStringExpander refactor

2010-01-29 Thread Adrian Crum
Adrian Crum wrote: --- On Thu, 1/28/10, Adam Heath doo...@brainfood.com wrote: From: Adam Heath doo...@brainfood.com Subject: Re: Discussion: FlexibleStringExpander refactor To: dev@ofbiz.apache.org Date: Thursday, January 28, 2010, 4:39 PM Adrian Crum wrote: Adam Heath wrote: Adrian Crum

Discussion: FlexibleStringExpander refactor

2010-01-28 Thread Adrian Crum
When I refactored FlexibleStringExpander.java a while ago (rev 687442), there were things I wanted to improve but couldn't - because I wanted to maintain backward-compatibility. Adam's recent memory-saving efforts reminded me of one of the things I wanted to change in

Re: Discussion: FlexibleStringExpander refactor

2010-01-28 Thread Adam Heath
Adrian Crum wrote: When I refactored FlexibleStringExpander.java a while ago (rev 687442), there were things I wanted to improve but couldn't - because I wanted to maintain backward-compatibility. Adam's recent memory-saving efforts reminded me of one of the things I wanted to change in

Re: Discussion: FlexibleStringExpander refactor

2010-01-28 Thread Adrian Crum
Adam Heath wrote: Adrian Crum wrote: When I refactored FlexibleStringExpander.java a while ago (rev 687442), there were things I wanted to improve but couldn't - because I wanted to maintain backward-compatibility. Adam's recent memory-saving efforts reminded me of one of the things I wanted

Re: Discussion: FlexibleStringExpander refactor

2010-01-28 Thread Adam Heath
Adrian Crum wrote: That's it. If you want to know how this will benefit memory use, read on... Consider this mini-language statement: set field=isTrue value=Y/ The value attribute is kept in memory as a FlexibleStringExpander instance. That instance will contain one instance of

Re: Discussion: FlexibleStringExpander refactor

2010-01-28 Thread Adam Heath
Adrian Crum wrote: Adam Heath wrote: Adrian Crum wrote: When I refactored FlexibleStringExpander.java a while ago (rev 687442), there were things I wanted to improve but couldn't - because I wanted to maintain backward-compatibility. Adam's recent memory-saving efforts reminded me of one of

Re: Discussion: FlexibleStringExpander refactor

2010-01-28 Thread Adrian Crum
Adam Heath wrote: Adrian Crum wrote: That's it. If you want to know how this will benefit memory use, read on... Consider this mini-language statement: set field=isTrue value=Y/ The value attribute is kept in memory as a FlexibleStringExpander instance. That instance will contain one

Re: Discussion: FlexibleStringExpander refactor

2010-01-28 Thread Adam Heath
Adrian Crum wrote: Adam Heath wrote: Adrian Crum wrote: Adam Heath wrote: Adrian Crum wrote: When I refactored FlexibleStringExpander.java a while ago (rev 687442), there were things I wanted to improve but couldn't - because I wanted to maintain backward-compatibility. Adam's recent

Re: Discussion: FlexibleStringExpander refactor

2010-01-28 Thread Adrian Crum
--- On Thu, 1/28/10, Adam Heath doo...@brainfood.com wrote: From: Adam Heath doo...@brainfood.com Subject: Re: Discussion: FlexibleStringExpander refactor To: dev@ofbiz.apache.org Date: Thursday, January 28, 2010, 4:39 PM Adrian Crum wrote: Adam Heath wrote: Adrian Crum wrote: Adam