Pierre,
I did not receive your message in dev ML, certainly due to my too much Thunderbird Filters or maybe something else, strange things happen with mails
sometimes.
So it's here forwarded expurged from exchanges in members private ML with last
line slightly modified.
HTH
-------- Message transféré --------
Sujet : Re: [GitHub] [ofbiz-framework] mbrohl commented on pull request
#498: Improved: WorkEffort - MainActionMenu (OFBIZ-12557)
Date : Fri, 4 Feb 2022 11:01:16 +0100
De : Jacques Le Roux <jacques.le.r...@les7arts.com>
Répondre à : memb...@apache.org
Pour : memb...@apache.org
Hi Pierre,
You missed the point. You confuse changes and history. The problem here is mixing formatting and code changes complicates the reviews, nothing more. I
trust it's just laziness and you are not doing that on purpose. But I begin to seriously doubt.
In your point 3 reference I then gave my opinion. I notably said to to Michael:
<<I'd not advice to set a rule for that, else, in the absolute, we would have to
change everywhere it's already not conform to the new rule >>
I thought you would be reasonable enough to understand it's more review work for committers. And would accept to change (I guess) your blank lines
removing automated setting and rebuild few PRs. It's a pity you preferred to escalate, exposing this problem to all members.
This said in the past, we already, a number of times, used regexps to globally change things in code. We could do that again and establish a new rule
that would be covered by the build blocking checkstyle Gradle task, hence blocking PRs and commits with no blank lines in some part of code. Rarely
but sometimes something must be done in code
I did not said I'll do that, it would take much time (tests and failures), just
the kind of escalation that would seem more appropriate to me.
I embrace "community over code" but sorry I don't think you are going in the
right direction.
Jacques
On Thu, Feb 3, 2022 at 4:57 PM Pierre Smits <pierresm...@apache.org>
wrote:
Indeed, Michael. That was what you said in comments regarding:
1. https://github.com/apache/ofbiz-framework/pull/481
2. https://github.com/apache/ofbiz-framework/pull/482
3. https://github.com/apache/ofbiz-framework/pull/483
and now again in https://github.com/apache/ofbiz-framework/pull/498
What is this RULE of yours that fellow volunteering contributors
MUST comply with in order to have their improvements go into the codebase:
Is
it
single
line
spacing,
*or*
Is
ig
double
line
spacing?
It must surely feel very frustrating and annoying (even maybe
painful?) when YOU look at code in the OFBiz repositories and the majority
of that code not having the single or double line spacing that you
want.
How unfortunate that all those contributors of code improvements
over the past 15 years of this project's existence (including you,
contributing for as long as that, as your claimed elsewhere)
violated that RULE of yours (that you brought forward just 11 days ago).
If the code of OFBiz (and improvements thereon) give you so much
difficulties to read, maybe there are some helpful tools available for
you to continue to bring your valuable contributions to improve
this project and its works? Or maybe it is time to call it quits?
Met vriendelijke groet,
Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/>
since 2008 (without privileges)
Proud contributor to the ASF since 2006
*Apache Directory <https://directory.apache.org>, PMC Member*
*
*
Anyone could have been you, whereas I've always been anyone.
On Thu, Feb 3, 2022 at 8:12 PM GitBox <g...@apache.org> wrote:
mbrohl commented on pull request #498:
URL:
https://github.com/apache/ofbiz-framework/pull/498#issuecomment-1029313372
As said before, the removal of blank lines between sections
makes the files harder to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@ofbiz.apache.org
For queries about this service, please contact Infrastructure
at:
us...@infra.apache.org
