Re: LineLength for checkstyle

Thanks Jacques. Using this I think we would also be able to configure like, hey don't check for services java files, they don't have default constructors ;) -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co

Re: LineLength for checkstyle

Hi All, I agree with Daniel and Suraj. Do we would set a rule to 2000 to not let the same default (2000). We should also decide for the exceptions, wrote (eg following[1] and [2]) and note them in OFBIZ-11740. Pierre, see OFBIZ-11740 [1]

Re: LineLength for checkstyle

How many files would violate that 2000-lines rule? Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion , Vice President* *Apache Directory

Re: LineLength for checkstyle

+1 for setting rule. Also we can think of some configured values instead of 2000 (default). may be we should set it to 3000 instead. And then as Daniel mentioned, work on refactoring those offending source files where possible. -- Best Regards, Suraj Khurana Senior Technical Consultant On

Re: LineLength for checkstyle

+1 for setting the max lines rule > Am 25.05.2020 um 17:05 schrieb Daniel Watford : > > Hi Jacques, > > I would vote for setting an explicit rule to have the max line length set > at 2000 lines and then work on refactoring those offending source files > where possible. > > If we find some

Re: LineLength for checkstyle

Hi Jacques, I would vote for setting an explicit rule to have the max line length set at 2000 lines and then work on refactoring those offending source files where possible. If we find some files cannot be split up then I think we can add exceptions to prevent the max line length rule from being

Re: LineLength for checkstyle

Hi All, Suraj rightly mentioned that we have no FileLength checkstyle rule and the max default is 2000 lines: https://checkstyle.sourceforge.io/config_sizes.html#FileLength We have some very large Java files in trunk and few (19) are longer than 2000 lines. The question is should we increase

Re: LineLength for checkstyle

This is done in rev # d6ebef619349f809062641d1b558cacdec3da208 -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, May 25, 2020 at 2:16 PM Suraj Khurana wrote: > Thanks everyone, > > Here[1] is the ticket to track this improvement. > > [1]:

Re: LineLength for checkstyle

Thanks everyone, Here[1] is the ticket to track this improvement. [1]: https://issues.apache.org/jira/browse/OFBIZ-11737 -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, May 24, 2020 at 1:58 PM Olivier Heintz < holivier.li...@ofbizextra.org> wrote: > +1 > > Le 23/05/2020 à

Re: LineLength for checkstyle

+1 Le 23/05/2020 à 17:29, Suraj Khurana a écrit : > Hello Devs, > > Recently we are facing some checkstyle issues and one cause of it is > LineLength property. > Currently we have set it to 120, I think we should make it to 150 instead. > It is pretty visible in 13/14 font sizes as well. > >

Re: LineLength for checkstyle

+1 Thanks. -- Mridul Pathak > On 23-May-2020, at 8:59 PM, Suraj Khurana wrote: > > Hello Devs, > > Recently we are facing some checkstyle issues and one cause of it is > LineLength property. > Currently we have set it to 120, I think we should make it to 150 instead. > It is pretty visible

Re: LineLength for checkstyle

+1 Thanks and Regards, Aditya Sharma On Sat, May 23, 2020 at 10:16 PM Pawan Verma wrote: > +1 > > Pawan >

Re: LineLength for checkstyle

+1 Pawan

Re: LineLength for checkstyle

+1 Jacques Le 23/05/2020 à 17:29, Suraj Khurana a écrit : Hello Devs, Recently we are facing some checkstyle issues and one cause of it is LineLength property. Currently we have set it to 120, I think we should make it to 150 instead. It is pretty visible in 13/14 font sizes as well. Please

LineLength for checkstyle

Hello Devs, Recently we are facing some checkstyle issues and one cause of it is LineLength property. Currently we have set it to 120, I think we should make it to 150 instead. It is pretty visible in 13/14 font sizes as well. Please share your thoughts on this. -- Best Regards, Suraj Khurana