Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2021-01-14 Thread Eugen Stan
Hi, See my reply inline: Regards, Eugen On 14.01.2021 18:02, Daniel Watford wrote: Hi Eugen, I think your point... > It's important to match the driver version with database version ... is a good reason for the ofbiz project to NOT be opinionated about database libraries and versions

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2021-01-14 Thread Daniel Watford
Hi Eugen, I think your point... > It's important to match the driver version with database version ... is a good reason for the ofbiz project to NOT be opinionated about database libraries and versions Originally I had only thought we would need to specify one driver for one DBMS type. I had

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2021-01-14 Thread Daniel Watford
Hi Jacques, I don't recall a conversation on the mailing list about breaking up entityengine.xml, however Eugen did suggest creating some templates in the context of the PR related to this thread ( https://github.com/apache/ofbiz-framework/pull/246) which I then implemented for Postgres and Derby

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2021-01-14 Thread Eugen Stan
Hi, Please see my reply inline: On 14.01.2021 16:21, Daniel Watford wrote: Hi Eugen, I like the approach of a config directory which can be used to override configuration files already compiled into a distribution (distTar/distZip). It's probably worth opening a separate ticket for that since

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2021-01-14 Thread Jacques Le Roux
Hi Daniel, James, Did we not recently discuss about splitting entityengine.xml and could not get a consensus? (I searched but did not find it) Thanks Jacques Le 14/01/2021 à 15:21, Daniel Watford a écrit : Hi Eugen, I like the approach of a config directory which can be used to override

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2021-01-14 Thread James Yong
Hi Daniel, IMO, splitting entityengine.xml file into db-specific is good in general. I have the following suggestions: Gradle Allow more 1 db driver to be downloaded. Different datasource can be in use at the same time, like mysql for olap and postgreql for others. Non-Gradle Allow

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2021-01-14 Thread Daniel Watford
Hi Eugen, I like the approach of a config directory which can be used to override configuration files already compiled into a distribution (distTar/distZip). It's probably worth opening a separate ticket for that since it would be analogous to how the /lib directory is currently used for gradle

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2021-01-12 Thread Eugen Stan
Hello Daniel, I'll re-post with updates my github comment here since I imagine not everyone will read the PR comments. I think trying to meddle with those configs at build time is brittle and would complicate the build. It would help to have the ability to add jars and configuration files

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2021-01-12 Thread Daniel Watford
Hello, I'd like to get opinions from the devs on whether it is worth pursuing changes to include database driver resolution in ofbiz builds. PR246 (https://github.com/apache/ofbiz-framework/pull/246) was an experiment to try and configure an instance of ofbiz from the gradle build, covering

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2020-12-12 Thread Jacques Le Roux
Hi NANJUNDA, Your message has been moderated, else it would not have reached this Mailing List. Please subscribe to the user ML for such questions and then use your email client. See why here http://ofbiz.apache.org/mailing-lists.html. You will get a better support, people can answer you on

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2020-12-12 Thread NANJUNDA MURTHY
Good evening i plan to install ofbiz but iam getting gradle error On 2020/11/30 20:45:52, Daniel Watford wrote: > Hello, > > I'ved added a PR for OFBIZ-12081 where I add a gradle runtime dependency to > download a specific database driver. Currently I have only added a driver > for Postgres,

OFBIZ-12081: DB driver download and configuration based on gradle property

2020-11-30 Thread Daniel Watford
Hello, I'ved added a PR for OFBIZ-12081 where I add a gradle runtime dependency to download a specific database driver. Currently I have only added a driver for Postgres, but it should be simple to nominate drivers for other DBMS where they can be downloaded and distributed. Are there any issues