Re: Permission service not on the same transaction

2017-12-15 Thread Nicolas Malin
No worries, I agree we can wait after de 17 to improve this part Nicolas Le 14/12/2017 à 23:22, Jacques Le Roux a écrit : Thanks Nicolas, Sorry, I completely forgot about that. I'll have a look ASAP, but after https://issues.apache.org/jira/browse/OFBIZ-10047 that I want in R17 :) Jacques

Re: Permission service not on the same transaction

2017-12-14 Thread Jacques Le Roux
Thanks Nicolas, Sorry, I completely forgot about that. I'll have a look ASAP, but after https://issues.apache.org/jira/browse/OFBIZ-10047 that I want in R17 :) Jacques Le 14/08/2017 à 20:40, Nicolas Malin a écrit : Hi Jacques, All is present on the issue OFBIZ-7113

Re: Permission service not on the same transaction

2017-08-14 Thread Nicolas Malin
Hi Jacques, All is present on the issue OFBIZ-7113 But I think the patch doesn't up to date. It contains big change, I will review quietly if you think it would be a good improvement Nicolas Le 12/08/2017 à 10:23, Jacques Le Roux a écrit :

Re: Permission service not on the same transaction

2017-08-12 Thread Jacques Le Roux
Hi Nicolas, Just stumbled upon this. Is there a Jira? What is the revision commit number? Thanks Jacques (sent from PonyMail) On 2016-04-14 21:03, Nicolas Malin wrote: > No remarks on this case ? > > If the silent is present I open an issue and commit this patch ;) > > Nicolas > > Le 07/04/

Re: Permission service not on the same transaction

2016-09-21 Thread Nicolas Malin
Hi Rishi, in line Le 19/09/2016 à 16:20, Rishi Solanki a écrit : Nicolas, "If you are dealing with money, or precision is a must, use BigDecimal. Otherwise Doubles tend to be good enough." That means, for quantity fields double should be fine. But within OFBiz, I see entities like OrderItem, O

Re: Permission service not on the same transaction

2016-09-20 Thread Pierre Smits
The estimate quantity is coming from manufacturing where the calculation of quantities in tasks and production runs is based on fractions register in product associations (BoM). So simplification doesn't work. Best regards,. Pierre Smits ORRTIZ.COM OFBiz based solutions

Re: Permission service not on the same transaction

2016-09-19 Thread Jacques Le Roux
This could be related https://issues.apache.org/jira/browse/OFBIZ-6386 (did not check anything, just a souvenir) Jacques Le 19/09/2016 à 16:20, Rishi Solanki a écrit : Nicolas, "If you are dealing with money, or precision is a must, use BigDecimal. Otherwise Doubles tend to be good enough."

Re: Permission service not on the same transaction

2016-09-19 Thread Rishi Solanki
Nicolas, "If you are dealing with money, or precision is a must, use BigDecimal. Otherwise Doubles tend to be good enough." That means, for quantity fields double should be fine. But within OFBiz, I see entities like OrderItem, OISGIR, and many other uses BigDecimal for quantity field. But I think

Re: Permission service not on the same transaction

2016-09-17 Thread Nicolas Malin
Hi all, I need some Help !! I put my arm in a gearing :( After refactor the permission service, I raise a silent problem that is all call-service used on mini-lang test didn't passed to service validation. I correct some easier case like bad attribut passed but now rest some complicate case l

Re: Permission service not on the same transaction

2016-04-19 Thread Nicolas Malin
Hi Taher, It's true :) and it's a beautiful copy paste ! Now my deep think would be that both call are wrong (not wrong but not finalized) because the permission eval call a service. And a service give the information if he will run on new transaction so we need to check on the service defini

Re: Permission service not on the same transaction

2016-04-19 Thread Nicolas Malin
Hi Pranay, Sorry for the latency Le 15/04/2016 08:18, Pranay Pandey a écrit : Hi Nicolas, Calling it as permission service is tricky. I see the comment in implementation above the simple method in ShipmentServices.xml- It was implemented with a purpose to be called inline, may be supporti

Re: Permission service not on the same transaction

2016-04-14 Thread Taher Alkhateeb
Hi Nicolas, I have to note that in ModelPermission the same exact call is also made with a new transaction. I did not dig deep into it but I advice to at least check it over there as well. This makes me suspect that either both call are wrong or both calls are right. HTH Taher Alkhateeb On Fri,

Re: Permission service not on the same transaction

2016-04-14 Thread Pranay Pandey
Hi Nicolas, Calling it as permission service is tricky. I see the comment in implementation above the simple method in ShipmentServices.xml- It was implemented with a purpose to be called inline, may be supporting the traditional way of doing things. Reviewing at a complete patch with all t

Re: Permission service not on the same transaction

2016-04-14 Thread Nicolas Malin
No remarks on this case ? If the silent is present I open an issue and commit this patch ;) Nicolas Le 07/04/2016 10:00, Nicolas Malin a écrit : Hello, Currently I continue the conversion on shipment crud service and I detected that many service use the same mini-lang call to check if the

Permission service not on the same transaction

2016-04-07 Thread Nicolas Malin
Hello, Currently I continue the conversion on shipment crud service and I detected that many service use the same mini-lang call to check if the shipment status is ok for editing "checkCanChangeShipmentStatusPacked" I convert it on service to call it directly by the permission-service like