Re: Issue with opening a bookmarked page when the user is logged out

2018-09-03 Thread Ritesh Kumar
Hello team, Thanks, everyone for your inputs. I have attached the patch on the ticket OFBIZ-10539 to fix the issue. Kindly have a look into this and let me know if there are any additional inputs. On Mon, Aug 27, 2018 at 11:20 AM Ritesh Kum

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Ritesh Kumar
Thanks, Girish for clearly explaining my concern and everyone for your inputs. I have created the ticket ( OFBIZ-10539 ). Soon, I will be providing the solution patch for review. On Sun, Aug 26, 2018 at 3:36 PM Michael Brohl wrote: > OFBiz hand

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Michael Brohl
OFBiz handles multiple request parameters with the same name well if you use POST requests. For GET requests, there seem to be no standard for multiple parameters with the same name, see [1]. I thinks it would be good to investigate further and see if we can fix this. I don't see a problem w

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Jacques Le Roux
Thanks Girish for your detailed analysis! Jacques Le 26/08/2018 à 06:57, Girish Vasmatkar a écrit : Hi Ritesh It does look like an issue to me. I believe (correct me if I am wrong) it is not so much about whether GET is appropriate here, it is more about that the framework is unable to handl

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Jacques Le Roux
Le 26/08/2018 à 11:20, Mathieu Lirzin a écrit : Taher Alkhateeb writes: Hmmm, based on Girish's feedback I think perhaps the next step should be to open a JIRA and further investigate. Thinking about it some more, maybe this would have an impact on the REST API project we're working on. The i

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Mathieu Lirzin
Taher Alkhateeb writes: > Hmmm, based on Girish's feedback I think perhaps the next step should be to > open a JIRA and further investigate. Thinking about it some more, maybe > this would have an impact on the REST API project we're working on. The issue seems indeed related. +1 for a opening

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-25 Thread Taher Alkhateeb
Hmmm, based on Girish's feedback I think perhaps the next step should be to open a JIRA and further investigate. Thinking about it some more, maybe this would have an impact on the REST API project we're working on. On Sun, Aug 26, 2018, 7:57 AM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.co

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-25 Thread Girish Vasmatkar
Hi Ritesh It does look like an issue to me. I believe (correct me if I am wrong) it is not so much about whether GET is appropriate here, it is more about that the framework is unable to handle multiple request parameters with same name, which is a common case when we talk about multiple check bo

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-25 Thread Taher Alkhateeb
Okay, I understand this issue. I don't think it is possible to abstract away a complex search screen with http GET method for bookmarks. The performFind service is quite complex and it is difficult to replicate the requirements using GET. GET is not designed to handle multiple languages, spaces, an

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-24 Thread Ritesh Kumar
Using the POST method does not append form data to the URL, i.e, the parameters will not be visible in the URL. For example, take a Find Screen (say, FindWorkEffort) which send data through a form with POST method. Apply some filters (say, status). No applied filters appear in the URL. Bookmark th

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-24 Thread Taher Alkhateeb
Not enough information. What happens exactly? What is the bug? What do you mean by it does not let us do that? On Fri, Aug 24, 2018, 11:09 AM Ritesh Kumar wrote: > Hello Taher, > > Changing form method to GET is just to make the query parameters visible in > the URL so that a user is able to boo

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-24 Thread Ritesh Kumar
Hello Taher, Changing form method to GET is just to make the query parameters visible in the URL so that a user is able to bookmark or share it. Using the POST method does not let us do that. On Fri, Aug 24, 2018 at 11:54 AM Taher Alkhateeb wrote: > Why did you change the method to GET? > > On

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-23 Thread Taher Alkhateeb
Why did you change the method to GET? On Fri, Aug 24, 2018, 9:20 AM Ritesh Kumar wrote: > Just to put my point more clearly, let me add the steps to generate the > above-mentioned case. Please refer demo-trunk > . > > 1. Open this link,

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-23 Thread Ritesh Kumar
Just to put my point more clearly, let me add the steps to generate the above-mentioned case. Please refer demo-trunk . 1. Open this link, FindWorkEffort . Find Work Ef