Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Jacques Le Roux
Adrian Crum wrote: On 5/30/2012 6:06 PM, Adam Heath wrote: On 05/30/2012 11:47 AM, Adrian Crum wrote: On 5/30/2012 4:30 PM, Adam Heath wrote: On 05/30/2012 02:46 AM, Adrian Crum wrote: On 5/29/2012 5:49 AM, Adam Heath wrote: On 05/25/2012 01:22 AM, Adam Heath wrote: On 05/25/2012 12:26 AM,

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Adrian Crum
On 5/30/2012 6:29 PM, Adam Heath wrote: On 05/30/2012 12:22 PM, Adrian Crum wrote: I need to reacquaint myself with the entity engine code. I was thinking the visitor pattern could be used to construct the SQL string instead of the complicated if-then-else code spread across a number of classes.

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Adam Heath
On 05/30/2012 12:22 PM, Adrian Crum wrote: > >>> I need to reacquaint myself with the entity engine code. I was >>> thinking the visitor pattern could be used to construct the SQL string >>> instead of the complicated if-then-else code spread across a number of >>> classes. We could use different

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Adrian Crum
On 5/30/2012 6:06 PM, Adam Heath wrote: On 05/30/2012 11:47 AM, Adrian Crum wrote: On 5/30/2012 4:30 PM, Adam Heath wrote: On 05/30/2012 02:46 AM, Adrian Crum wrote: On 5/29/2012 5:49 AM, Adam Heath wrote: On 05/25/2012 01:22 AM, Adam Heath wrote: On 05/25/2012 12:26 AM, Jacques Le Roux wro

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Adam Heath
On 05/30/2012 11:47 AM, Adrian Crum wrote: > > On 5/30/2012 4:30 PM, Adam Heath wrote: >> On 05/30/2012 02:46 AM, Adrian Crum wrote: >>> On 5/29/2012 5:49 AM, Adam Heath wrote: On 05/25/2012 01:22 AM, Adam Heath wrote: > On 05/25/2012 12:26 AM, Jacques Le Roux wrote: >> From: "Jacques

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Adrian Crum
On 5/30/2012 4:30 PM, Adam Heath wrote: On 05/30/2012 02:46 AM, Adrian Crum wrote: On 5/29/2012 5:49 AM, Adam Heath wrote: On 05/25/2012 01:22 AM, Adam Heath wrote: On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: "Jacques Le Roux" From: "Adam Heath" On 05/24/2012 04:05 PM, Jacques Le

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Adam Heath
On 05/30/2012 02:46 AM, Adrian Crum wrote: > On 5/29/2012 5:49 AM, Adam Heath wrote: >> On 05/25/2012 01:22 AM, Adam Heath wrote: >>> On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: "Jacques Le Roux" > From: "Adam Heath" >> On 05/24/2012 04:05 PM, Jacques Le Roux wrote: >>>

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Adrian Crum
On 5/29/2012 5:49 AM, Adam Heath wrote: On 05/25/2012 01:22 AM, Adam Heath wrote: On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: "Jacques Le Roux" From: "Adam Heath" On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: "Adam Heath" On 05/24/2012 10:18 AM, Adam Heath wrote: The idea

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-29 Thread Jacques Le Roux
Jacopo Cappellato wrote: On May 29, 2012, at 6:49 AM, Adam Heath wrote: Great, but still, why not a branch as long as it's not finished? Jacques branches/improved-entityengine-features-20120528 Also see 1343540, which adds a README that has some things that we might want to implement in t

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-29 Thread Jacques Le Roux
Adam Heath wrote: On 05/25/2012 01:22 AM, Adam Heath wrote: On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: "Jacques Le Roux" From: "Adam Heath" On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: "Adam Heath" On 05/24/2012 10:18 AM, Adam Heath wrote: The idea was that you would pa

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-29 Thread Jacopo Cappellato
On May 29, 2012, at 6:49 AM, Adam Heath wrote: Great, but still, why not a branch as long as it's not finished? Jacques > > branches/improved-entityengine-features-20120528 > > Also see 1343540, which adds a README that has some things that we might want > to implement in

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-28 Thread Adam Heath
On 05/25/2012 01:22 AM, Adam Heath wrote: On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: "Jacques Le Roux" From: "Adam Heath" On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: "Adam Heath" On 05/24/2012 10:18 AM, Adam Heath wrote: The idea was that you would parse the sqlConditio

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Jacques Le Roux
From: "Adam Heath" On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: "Jacques Le Roux" From: "Adam Heath" On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: "Adam Heath" On 05/24/2012 10:18 AM, Adam Heath wrote: The idea was that you would parse the sqlCondition once, in a static {}

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Adam Heath
On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: "Jacques Le Roux" From: "Adam Heath" On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: "Adam Heath" On 05/24/2012 10:18 AM, Adam Heath wrote: The idea was that you would parse the sqlCondition once, in a static {} block somewhere, the

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Pierre Smits
May be doing a little example code that shows how it works and the performance impact can help developers with implementation in various areas. Regards, Pierre 2012/5/25 Adam Heath > On 05/24/2012 04:05 PM, Jacques Le Roux wrote: > >> From: "Adam Heath" >> >>> On 05/24/2012 10:18 AM, Adam Hea

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Jacques Le Roux
From: "Jacques Le Roux" From: "Adam Heath" On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: "Adam Heath" On 05/24/2012 10:18 AM, Adam Heath wrote: On 05/24/2012 08:15 AM, Adrian Crum wrote: On 5/20/2012 10:01 AM, Jacques Le Roux wrote: Quick questions (seems that there is a lack of i

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Jacques Le Roux
From: "Adam Heath" On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: "Adam Heath" On 05/24/2012 10:18 AM, Adam Heath wrote: On 05/24/2012 08:15 AM, Adrian Crum wrote: On 5/20/2012 10:01 AM, Jacques Le Roux wrote: Quick questions (seems that there is a lack of internal documentation to s

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Adam Heath
On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: "Adam Heath" On 05/24/2012 10:18 AM, Adam Heath wrote: On 05/24/2012 08:15 AM, Adrian Crum wrote: On 5/20/2012 10:01 AM, Jacques Le Roux wrote: Quick questions (seems that there is a lack of internal documentation to say the least), there

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Jacques Le Roux
From: "Adam Heath" On 05/24/2012 10:18 AM, Adam Heath wrote: On 05/24/2012 08:15 AM, Adrian Crum wrote: On 5/20/2012 10:01 AM, Jacques Le Roux wrote: Quick questions (seems that there is a lack of internal documentation to say the least), there are not only addressed to Adam... About javacc

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Jacques Le Roux
Thanks Adrian Jacques From: "Adrian Crum" On 5/20/2012 10:01 AM, Jacques Le Roux wrote: Quick questions (seems that there is a lack of internal documentation to say the least), there are not only addressed to Adam... About javacc dependency do we really need it *OOTB*? Can't we use rather e

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Adam Heath
On 05/24/2012 10:18 AM, Adam Heath wrote: > On 05/24/2012 08:15 AM, Adrian Crum wrote: >> On 5/20/2012 10:01 AM, Jacques Le Roux wrote: >>> Quick questions (seems that there is a lack of internal >>> documentation to say the least), there are not only addressed to >>> Adam... >>> >>> About javacc d

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Adam Heath
On 05/24/2012 08:15 AM, Adrian Crum wrote: > On 5/20/2012 10:01 AM, Jacques Le Roux wrote: >> Quick questions (seems that there is a lack of internal >> documentation to say the least), there are not only addressed to >> Adam... >> >> About javacc dependency do we really need it *OOTB*? >> Can't we

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Adrian Crum
On 5/20/2012 10:01 AM, Jacques Le Roux wrote: Quick questions (seems that there is a lack of internal documentation to say the least), there are not only addressed to Adam... About javacc dependency do we really need it *OOTB*? Can't we use rather externally maintained ant targets like in ant-