Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2018-01-19 Thread Jacques Le Roux
framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ Thanks Deepak, Ha indeed, I see your point now. Sorry for the confusion! Jacques Le 16/01/2018 à 11:30, Deepak Dixit a écrit : Thanks Jacques for detail, but I think name is no

Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2018-01-18 Thread Shi Jinghai
Love you. :) -邮件原件- 发件人: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com] 发送时间: 2018年1月18日 21:02 收件人: dev@ofbiz.apache.org 主题: Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp

Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2018-01-18 Thread Jacques Le Roux
me specific environments, we can add an additional step to check "Authorisation" if getting "Authorization" header failed. -邮件原件- 发件人: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com] 发送时间: 2018年1月16日 18:52 收件人: dev@ofbiz.apache.org 主题: Re: svn commit: r1813679 - in /o

Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2018-01-17 Thread Shi Jinghai
送时间: 2018年1月16日 18:52 收件人: dev@ofbiz.apache.org 主题: Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ Thanks Deepak, Ha indeed, I see your point now. Sorry for the confusion! Jacques Le 16

Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2018-01-16 Thread Jacques Le Roux
Thanks Deepak, Ha indeed, I see your point now. Sorry for the confusion! Jacques Le 16/01/2018 à 11:30, Deepak Dixit a écrit : Thanks Jacques for detail, but I think name is not always Authorisation in code we are having lots of request.getHeader usage and its breaks their usage. I'll confir

Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2018-01-16 Thread Deepak Dixit
Thanks Jacques for detail, but I think name is not always Authorisation in code we are having lots of request.getHeader usage and its breaks their usage. I'll confirm and reply here (just for reference.) Need to backport this to 17.12 as well. Thanks & Regards -- Deepak Dixit www.hotwaxsystems.co

Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2018-01-16 Thread Jacques Le Roux
Le 16/01/2018 à 09:53, Deepak Dixit a écrit : +return super.getHeader("Authorisation"); I think this should be return super.getHeader(name); Thanks Deepak, Actually let me explain the context here (maybe not for you but at large) In the case of ExternalLoginKeysManager, it's

Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2018-01-16 Thread Deepak Dixit
Hi Jacques, > Modified: ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/ > java/org/apache/ofbiz/webapp/control/ContextFilter.java > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/ > framework/webapp/src/main/java/org/apache/ofbiz/webapp/ > control/ContextFilter.java?rev=181

Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2017-10-30 Thread Jacques Le Roux
Oops, thanks Deepak :) Fixed Jacques Le 30/10/2017 à 06:43, Deepak Dixit a écrit : Hi Jacques, +if (delegator != null && "Y".equals(EntityUtilProperties.getPropertyValue("embisphere", "use-external-server", "Y", delegator))) { I think ti should be security instead of embisphere :

Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2017-10-29 Thread Deepak Dixit
Hi Jacques, > +if (delegator != null && > "Y".equals(EntityUtilProperties.getPropertyValue("embisphere", > "use-external-server", "Y", delegator))) { > I think ti should be security instead of embisphere :)