Re: Removing some unnecessary synchronization for cache objects

2012-11-10 Thread Jacques Le Roux
I'm currently reading Java Concurrency in Practice and I agree on these change. I saw you continued at http://svn.apache.org/viewvc?view=revisionrevision=1343696, is that all? Jacques Jacopo Cappellato wrote: Hi devs, please review my commit below because I am working to apply a similar

Re: Removing some unnecessary synchronization for cache objects

2012-11-10 Thread Jacopo Cappellato
Hi Jacques, I did a first pass and completed most of them; but I know that there are still several areas with similar patterns and these could be enhanced as well with slightly different approaches. Kind regards, Jacopo On Nov 10, 2012, at 10:30 AM, Jacques Le Roux wrote: I'm currently

Removing some unnecessary synchronization for cache objects

2012-05-28 Thread Jacopo Cappellato
Hi devs, please review my commit below because I am working to apply a similar pattern to a lot of other classes in OFBiz. This effort is not a search-and-replace task but instead I am reviewing each individual usage of static UtilCache objects and refactoring (when necessary) the code to

Re: Removing some unnecessary synchronization for cache objects

2012-05-28 Thread Jacopo Cappellato
Please also review the following commit because it is another pattern I am going to apply to other code: On May 28, 2012, at 5:25 PM, jaco...@apache.org wrote: Author: jacopoc Date: Mon May 28 15:25:46 2012 New Revision: 1343278 URL: http://svn.apache.org/viewvc?rev=1343278view=rev Log:

Re: Removing some unnecessary synchronization for cache objects

2012-05-28 Thread Jacopo Cappellato
Please also review this one because I have other similar upcoming. Thanks, Jacopo On May 28, 2012, at 5:32 PM, jaco...@apache.org wrote: Author: jacopoc Date: Mon May 28 15:32:28 2012 New Revision: 1343287 URL: http://svn.apache.org/viewvc?rev=1343287view=rev Log: Improved code that

Re: Removing some unnecessary synchronization for cache objects

2012-05-28 Thread David E Jones
Looks like a good pattern. -David On May 28, 2012, at 9:27 AM, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: Please also review the following commit because it is another pattern I am going to apply to other code: On May 28, 2012, at 5:25 PM, jaco...@apache.org wrote: