Re: Restore common-theme with ofbiz-framework and now it's ready to play

2017-08-09 Thread Nicolas Malin
Hello, I push some little correction on the common-theme branch [1] (I have been detected that the specific-template macro used always html, you can see here [2] all commits) If you have some time to test it to have any feedback ! It's would be really appreciate because I prefer don't keep t

Re: Restore common-theme with ofbiz-framework and now it's ready to play

2017-07-28 Thread Nicolas Malin
It's with a great pleasure that can be announce : common-theme is operational ! Sure all isn't supported, but now can by theme surcharge : * widget properties * ftl template macro * common screen The maximum of image, js, ftl was moved from common to common-theme, implement a new object M

Re: Restore common-theme with ofbiz-framework

2017-07-27 Thread Nicolas Malin
Hi Jacques, Le 26/07/2017 à 19:32, Jacques Le Roux a écrit : Hi Nicolas, Maybe you can create a Jira (is there one already?) and add patches explaining they should not be committed but only reviewed. Especially when you feel your work is ready enough to be reviewed/used/tested even if not c

Re: Restore common-theme with ofbiz-framework

2017-07-26 Thread Jacques Le Roux
Hi Nicolas, Maybe you can create a Jira (is there one already?) and add patches explaining they should not be committed but only reviewed. Especially when you feel your work is ready enough to be reviewed/used/tested even if not committed. Taher does that sometimes, it's convenient for early r

Re: Restore common-theme with ofbiz-framework

2017-07-25 Thread Nicolas Malin
I continue the way and my recent success : * set the object theme always present for macro rendering * create a theme that extends common-theme and specially the htmlFormMacroLibrary with surchage only the renderDisplayField macro like that <#include "component://common-theme/template/macro/Ht

Re: Restore common-theme with ofbiz-framework

2017-07-21 Thread Nicolas Malin
Hello Taher, I continued my work on this subject and success to pass the main problem that I detected the last time. I create an xml definition for the theme and three class : ModelTheme : a threadsafe class to load each theme definition Theme : is a runnable classe that contains a modelTheme a

Re: Restore common-theme with ofbiz-framework

2017-07-18 Thread Nicolas Malin
Hi Taher, I understand the motivation but my work it's currently unstable. I continue to centralize the theme configuration for more stabilization. Nicolas Le 18/07/2017 à 16:54, Taher Alkhateeb a écrit : Hi Nicolas, Great stuff, I'm not sure what everyone thinks but I prefer if we can try

Re: Restore common-theme with ofbiz-framework

2017-07-18 Thread Taher Alkhateeb
Hi Nicolas, Great stuff, I'm not sure what everyone thinks but I prefer if we can try to get your work incorporated back into the code base as early as possible and to start completing the work from there. On Tue, Jul 18, 2017 at 5:38 PM, Nicolas Malin wrote: > Michael, > > I finished to restore

Restore common-theme with ofbiz-framework

2017-07-18 Thread Nicolas Malin
Michael, I finished to restore my work on common-theme from ofbiz to ofbiz-framework : https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 Now I will work on the java object to manage the widget theme on user session. Nicolas -- logoNrd