Re: Update: Screen Widget Refactor

2015-02-27 Thread Jacques Le Roux
reate a R14.12 freezed branch. Since then you worked on the screen widget refactor, I committed the SEO webapp in ecommerce: https://cwiki.apache.org/confluence/display/OFBIZ/ Search+Engine+Optimisation%2C+SEO+in+ecommerce and I'd like to also backport it to the R14 branch. I guess others woul

Re: Update: Screen Widget Refactor

2015-02-27 Thread Adrian Crum
today Jacques Le 25/02/2015 11:01, Jacques Le Roux a écrit : Hi Adrian, Sorry but I'm against this, or rather I have another suggestion to do. I will make it brief. We decided to create a R14.12 freezed branch. Since then you worked on the screen widget refactor, I committed the

Re: Update: Screen Widget Refactor

2015-02-27 Thread Jacques Le Roux
ug once reported. But I feel very alone today Jacques Le 25/02/2015 11:01, Jacques Le Roux a écrit : Hi Adrian, Sorry but I'm against this, or rather I have another suggestion to do. I will make it brief. We decided to create a R14.12 freezed branch. Since then you worked on the screen w

Re: Update: Screen Widget Refactor

2015-02-27 Thread Pierre Smits
2015 11:01, Jacques Le Roux a écrit : > > Hi Adrian, >> >> Sorry but I'm against this, or rather I have another suggestion to do. I >> will make it brief. >> >> We decided to create a R14.12 freezed branch. Since then you worked on >> the screen widge

Re: Update: Screen Widget Refactor

2015-02-27 Thread Jacques Le Roux
her I have another suggestion to do. I will make it brief. We decided to create a R14.12 freezed branch. Since then you worked on the screen widget refactor, I committed the SEO webapp in ecommerce: https://cwiki.apache.org/confluence/display/OFBIZ/Search+Engine+Optimisation%2C+SEO+in+ecommerce an

Re: Update: Screen Widget Refactor

2015-02-25 Thread Jacques Le Roux
Hi Adrian, Sorry but I'm against this, or rather I have another suggestion to do. I will make it brief. We decided to create a R14.12 freezed branch. Since then you worked on the screen widget refactor, I committed the SEO webapp in ecommerce: https://cwiki.apache.org/confluence/display/

Update: Screen Widget Refactor

2015-02-24 Thread Adrian Crum
d for others to innovate in this area of the project. I would like to backport the screen widget refactor to the R14 branch. The refactor fixed innumerable bugs and flaws in the previous code. If there are no strong objections, I will do the backport in a few days. Thank you everyone for your pat

Re: Screen Widget Refactor

2014-11-03 Thread Adrian Crum
I think I have successfully untangled the ModelForm.java code. The problem with the screen widget Java code is that most contributors and committers do not understand the architecture. This is probably due to the slight flaws in the architecture. My recent commits try to fix those flaws in Mod

Re: Screen Widget Refactor

2014-11-02 Thread Adrian Crum
Oh dear god. It's a good thing I'm going through this code. ModelForm.java is badly broken. C&P errors in the constructor, plus extended forms modify the state of the forms they extend. Adrian Crum Sandglass Software www.sandglass-software.com On 11/2/2014 2:12 PM, Adrian Crum wrote: I start

Re: Screen Widget Refactor

2014-11-02 Thread Jacques Le Roux
Thanks for your work Adrian! Jacques Le 02/11/2014 15:12, Adrian Crum a écrit : I started working on making the screen widgets thread-safe, but the quantity of code was overwhelming. So, I started reducing the widget code by reusing things, and by moving the Artifact Info code to a separate

Screen Widget Refactor

2014-11-02 Thread Adrian Crum
I started working on making the screen widgets thread-safe, but the quantity of code was overwhelming. So, I started reducing the widget code by reusing things, and by moving the Artifact Info code to a separate class. Screen widgets, form widgets, menu widgets, and tree widgets all share th

Re: Proposal: 2011 Screen Widget Refactor/Enhancement Initiative

2011-01-23 Thread Adrian Crum
Cool - thanks! We have all year. ;-) -Adrian On 1/22/2011 2:16 AM, Jacques Le Roux wrote: Hi Adrian, It's not a top priorities for me at the moment (I want to clean as much possible pending things before beginning any new things), but I would be interested to participate in the future Jacq

Some other propositions [ was Proposal: 2011 Screen Widget Refactor/Enhancement Initiative]

2011-01-22 Thread Jacques Le Roux
Hi Adrian, You suggested to create another thread for other propositions. I'd like to * handle spaces between fields using position * add a size attribute to the date-time field element * reverse the automatically generated postions of operator and value in minilang. It's minor, (hence easy, and

Re: Proposal: 2011 Screen Widget Refactor/Enhancement Initiative

2011-01-22 Thread Jacques Le Roux
Hi Adrian, It's not a top priorities for me at the moment (I want to clean as much possible pending things before beginning any new things), but I would be interested to participate in the future Jacques From: "Adrian Crum" >From time to time suggestions are made on how to improve the screen

Proposal: 2011 Screen Widget Refactor/Enhancement Initiative

2011-01-16 Thread Adrian Crum
>From time to time suggestions are made on how to improve the screen widgets. >Most often, there is some discussion about the idea and then things fizzle >out. Sometimes patches are submitted to Jira. Sometimes those patches make it >into the project. There have been some great ideas proposed a