Re: ShoppingCart.getPartyDaysSinceCreated

2010-03-27 Thread Adrian Crum
--- On Fri, 3/26/10, Adam Heath wrote: > Adrian Crum wrote: > > --- On Fri, 3/26/10, Adam Heath > wrote: > >> Scott Gray wrote: > >>> On 26/03/2010, at 5:13 PM, Adam Heath wrote: > >>> > The above method makes use of a > BigDecimal. > >> This is wrong.  It should > be an int.  Original

Re: ShoppingCart.getPartyDaysSinceCreated

2010-03-26 Thread Adam Heath
Adrian Crum wrote: > --- On Fri, 3/26/10, Adam Heath wrote: >> Scott Gray wrote: >>> On 26/03/2010, at 5:13 PM, Adam Heath wrote: >>> The above method makes use of a BigDecimal. >> This is wrong. It should be an int. Originally, before the BigDecimal >> conversion, it was a Doubl

Re: ShoppingCart.getPartyDaysSinceCreated

2010-03-26 Thread Adam Heath
Adrian Crum wrote: > --- On Fri, 3/26/10, Adam Heath wrote: >> Scott Gray wrote: >>> On 26/03/2010, at 5:13 PM, Adam Heath wrote: >>> The above method makes use of a BigDecimal. >> This is wrong. It should be an int. Originally, before the BigDecimal >> conversion, it was a Doubl

Re: ShoppingCart.getPartyDaysSinceCreated

2010-03-26 Thread Adam Heath
Scott Gray wrote: > On 26/03/2010, at 6:32 PM, Adam Heath wrote: > >> Scott Gray wrote: >>> On 26/03/2010, at 5:13 PM, Adam Heath wrote: >>> The above method makes use of a BigDecimal. This is wrong. It should be an int. Originally, before the BigDecimal conversion, it was a Doub

Re: ShoppingCart.getPartyDaysSinceCreated

2010-03-26 Thread Scott Gray
On 26/03/2010, at 6:32 PM, Adam Heath wrote: > Scott Gray wrote: >> On 26/03/2010, at 5:13 PM, Adam Heath wrote: >> >>> The above method makes use of a BigDecimal. This is wrong. It should >>> be an int. Originally, before the BigDecimal conversion, it was a >>> Double. This method should hav

Re: ShoppingCart.getPartyDaysSinceCreated

2010-03-26 Thread Adrian Crum
--- On Fri, 3/26/10, Adam Heath wrote: > Scott Gray wrote: > > On 26/03/2010, at 5:13 PM, Adam Heath wrote: > > > >> The above method makes use of a BigDecimal.  > This is wrong.  It should > >> be an int.  Originally, before the BigDecimal > conversion, it was a > >> Double.  This method should

Re: ShoppingCart.getPartyDaysSinceCreated

2010-03-26 Thread Adam Heath
Scott Gray wrote: > On 26/03/2010, at 5:13 PM, Adam Heath wrote: > >> The above method makes use of a BigDecimal. This is wrong. It should >> be an int. Originally, before the BigDecimal conversion, it was a >> Double. This method should have never been converted. > > It looked like a good ca

Re: ShoppingCart.getPartyDaysSinceCreated

2010-03-26 Thread Scott Gray
On 26/03/2010, at 5:13 PM, Adam Heath wrote: > The above method makes use of a BigDecimal. This is wrong. It should > be an int. Originally, before the BigDecimal conversion, it was a > Double. This method should have never been converted. It looked like a good candidate at the time and looki

ShoppingCart.getPartyDaysSinceCreated

2010-03-26 Thread Adam Heath
The above method makes use of a BigDecimal. This is wrong. It should be an int. Originally, before the BigDecimal conversion, it was a Double. This method should have never been converted. Also, it does time internal calculation wrong. It will have the same daylight savings time problem, when