Re: production-run-tests.testProductionRunDateChange

2010-03-14 Thread Jacopo Cappellato
Thanks, I have fixed it (and re enabled) in rev. 922813 I have used the trick to compare for equality but also accept a difference of +1 or -1 It should be ok for this test. Jacopo On Mar 13, 2010, at 5:39 PM, Adrian Crum wrote: --- On Sat, 3/13/10, Jacopo Cappellato

Re: production-run-tests.testProductionRunDateChange

2010-03-13 Thread Jacopo Cappellato
On Mar 13, 2010, at 6:48 AM, Adrian Crum wrote: Understanding the difference between wall clock time and elapsed time is especially important in manufacturing. They are completely different, and manufacturing depends on both. The problem with the test is it advances the wall clock,

Re: production-run-tests.testProductionRunDateChange

2010-03-13 Thread Jacopo Cappellato
Adam, Adrian, in the meantime thanks for the bug report (on the automated test!), I have disabled it for now and I will bring it back as soon as I will fix it. Jacopo On Mar 13, 2010, at 6:48 AM, Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adam Heath

Re: production-run-tests.testProductionRunDateChange

2010-03-13 Thread Adrian Crum
: production-run-tests.testProductionRunDateChange To: dev@ofbiz.apache.org Date: Saturday, March 13, 2010, 3:19 AM Adam, Adrian, in the meantime thanks for the bug report (on the automated test!), I have disabled it for now and I will bring it back as soon as I will fix it. Jacopo On Mar 13

Re: production-run-tests.testProductionRunDateChange

2010-03-13 Thread Adrian Crum
--- On Sat, 3/13/10, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: On Mar 13, 2010, at 6:48 AM, Adrian Crum wrote: Understanding the difference between wall clock time and elapsed time is especially important in manufacturing. They are completely different, and

production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adam Heath
ah ha! This is just excellent. Has anyone tried running the test suite right now? In the US? The above test fails, because the start date is now, but the end date is in the future *past* when daylight savings time takes place. So the interval is off by one hour, and the assertion fails. Does

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the test suite right now?  In the US? The above test fails, because the start date is now, but the end date is in the future *past* when daylight savings time takes

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adam Heath
Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the test suite right now? In the US? The above test fails, because the start date is now, but the end date is in the future *past* when daylight

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the test suite right now?  In the US? The above test fails, because the start date

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adam Heath
Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the test suite right now? In the US? The above test fails, because the

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adam Heath
Adam Heath wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the test suite right now? In the US? The above test

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adam Heath
Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adam Heath wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has