Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-05-05 Thread Jacques Le Roux
Done at r1334336, backported in R12.04 Jacques From: "Jacques Le Roux" From: "Scott Gray" That's an understatement and could actually be said of every patch in jira, shall we just go ahead and commit them all? We can improve them later right? Reading an xml file character by character to

Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-05-01 Thread Jacques Le Roux
From: "Scott Gray" That's an understatement and could actually be said of every patch in jira, shall we just go ahead and commit them all? We can improve them later right? Reading an xml file character by character to find something is like driving in a nail with the claw side of a hammer. I

Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-04-30 Thread Scott Gray
That's an understatement and could actually be said of every patch in jira, shall we just go ahead and commit them all? We can improve them later right? Reading an xml file character by character to find something is like driving in a nail with the claw side of a hammer. It sort of works, but

Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-04-30 Thread Jacques Le Roux
You are right Scott, this can be improved... Jacques From: "Scott Gray" This is not a good implementation, simply searching the web.xml file for a string containing "" is not good enough. It'll find the tag even if commented out and and won't find the tag "" (space before closing, perfectly

Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-04-30 Thread Jacques Le Roux
Ha yes, I already put a comment there and it's actually clear: you need to set both to have a webapp distributable ie in ofbiz-container.catalina-container AND in each webapp you want to distribute Jacques From: "Pierre Smits" Looking for 'distributable' I found no reference in any web.xml.

Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-04-30 Thread Pierre Smits
Looking for 'distributable' I found no reference in any web.xml. However I found in *-containers.xml the reference: If I understand it correctly than this overrides any or in web.xml files. So it could be safe to have it in any web.xml. Shall I provide a patch for the code used by the proc

Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-04-30 Thread Scott Gray
This is not a good implementation, simply searching the web.xml file for a string containing "" is not good enough. It'll find the tag even if commented out and and won't find the tag "" (space before closing, perfectly valid). I'm surprised this got past you Jacques. Regards Scott On 1/05/2

Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-04-30 Thread Jacques Le Roux
Pierre, I did not test, but I believe it's only used in a clustered environment and should have any impacts in other cases. It makes only a webapp distributable. Before we added this, all were distributable by default, which could annoying in certain circumstances. So adding it in web.xml file

Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-04-30 Thread Pierre Smits
Jacques, If I have this tag in the web.xml, but the change is tested in an unclustered environment what do you thing the result would be? Is it of no effect, would it fail? Regards, Pierre 2012/4/30 Jacques Le Roux > Hi Sam, > > Yes: http://tomcat.apache.org/**tomcat-6.0-doc/cluster-howto.**

Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-04-30 Thread Jacques Le Roux
Hi Sam, Yes: http://tomcat.apache.org/tomcat-6.0-doc/cluster-howto.html#Cluster_Basics http://wiki.metawerx.net/Wiki.jsp?page=web.xml.Distributable Also consider (false by default) If you use sticky sessions all above is not an issue... Maybe we should ask a comment in *-containers.xml BTW..

Re: svn commit: r1326064 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/FileUtil.java catalina/src/org/ofbiz/catalina/container/CatalinaContainer.java

2012-04-30 Thread Sam Hamilton
Hi Jacques, Quick question - does this setting mean that now if you uncomment framework/config/ofbiz-containers.xml cluster settings it wont cluster and that you should also add a tag to all the web.xml files? Thanks Sam On 14 Apr 2012, at 15:30, jler...@apache.org wrote: > Author: jlerou