Re: svn commit: r1331811 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/callops/AddError.java

2012-05-11 Thread Adrian Crum
Fixed in revision 1337092. Thanks Scott! The add-error + check-errors element combination and interaction was very confusing to me. In some places it is used as you described, and in other places the add-error element was used to simply create a list of messages. Plus, in the original code,

Re: svn commit: r1331811 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/callops/AddError.java

2012-05-11 Thread Adrian Crum
Oops, I missed two lines while changing it back. Fixed in rev 1337103. -Adrian On 5/11/2012 10:56 AM, Adrian Crum wrote: Fixed in revision 1337092. Thanks Scott! The add-error + check-errors element combination and interaction was very confusing to me. In some places it is used as you

Re: svn commit: r1331811 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/callops/AddError.java

2012-05-11 Thread Scott Gray
Awesome thanks for the quick response Adrian. I'll admit to not knowing much about it but my understanding has always been that the method exits immediately if an internal error is generated. Regards Scott On 11/05/2012, at 10:27 PM, Adrian Crum wrote: Oops, I missed two lines while

Re: svn commit: r1331811 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/callops/AddError.java

2012-05-10 Thread Scott Gray
Hi Adrian, add-error + check-errors/ doesn't seem to be working for minilang events anymore. For example: https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/AnonContactus Submitting that form while completely empty returns successfully even though the event has validation for the