This looks good, but please leave the thread-safe fields as final. See
inline comment...
On 5/23/2013 8:55 AM, jler...@apache.org wrote:
Author: jleroux
Date: Thu May 23 07:55:14 2013
New Revision: 1485601
URL: http://svn.apache.org/r1485601
Log:
Add a mean to collect and show the Requests
Yes sorry, this was a 1st try I did before changing directly in factory, I
forgot to remove, I will.
Always better to have at least 2 pairs of eyes...
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
This looks good, but please leave the thread-safe fields as final. See
inline
Thanks.
As you can see, adding metrics to OFBiz is fairly simple. That is why I
objected to adding redundant code to the Metrics classes.
-Adrian
On 5/23/2013 9:57 AM, Jacques Le Roux wrote:
Yes sorry, this was a 1st try I did before changing directly in factory, I
forgot to remove, I
Yes, I should have thought about using the model, rather than mucking around
with Metric classes. But it was a bit more complicated so I got this wrong way.
BTW, I just thought about something.
Convention above configuration is often good, but here the metrics names rely
on hand writing. So
Yes, I should have thought about using the model, rather than mucking around
with Metric classes. But it was a bit more complicated so I went this wrong way.
BTW, I just thought about something.
Convention above configuration is often good, but here the metrics names rely
on hand writing. So
