Re: svn commit: r1495294 - in /ofbiz/trunk/applications/accounting: script/org/ofbiz/accounting/invoice/InvoiceServices.xml script/org/ofbiz/accounting/payment/PaymentServices.xml servicedef/services_

2013-06-24 Thread Adrian Crum
I checked the DMRB, and it shows the bill to party ID and bill from party ID specified in the INVOICE entity, so the current implementation is correct. It wasn't clear to me what those roles were in the OFBiz model because the field names are ambiguous. -Adrian On 6/23/2013 5:05 AM, Hans Bakk

Re: svn commit: r1495294 - in /ofbiz/trunk/applications/accounting: script/org/ofbiz/accounting/invoice/InvoiceServices.xml script/org/ofbiz/accounting/payment/PaymentServices.xml servicedef/services_

2013-06-22 Thread Hans Bakker
Hi Adrian, Thank you for your interest in the changes i am currently implementing in the accounting system. Your name change is a fine suggestion and is already implementedin revision 1495791. Your suggestion of the invoiceroles I not really understand. I may be wrong but currently invoicerol

Re: svn commit: r1495294 - in /ofbiz/trunk/applications/accounting: script/org/ofbiz/accounting/invoice/InvoiceServices.xml script/org/ofbiz/accounting/payment/PaymentServices.xml servicedef/services_

2013-06-21 Thread Adrian Crum
If the service is meant to "check if a invoice is in a foreign currency related to the accounting company", then it might be best to rename it to "isInvoiceForeignCurrency". Also, wouldn't it be better to check the InvoiceRole entity? Those party ID fields are ambiguous. -Adrian On 6/21/201