Done at r1611311
Jacques
Le 17/07/2014 07:13, Jacopo Cappellato a écrit :
Thanks, it is better now but I still think that this contribution needed a more
accurate review: a catch block for NumberFormatException would be useful (to
log the configuration error as warning and set the default
I see some ugly formatting and variable names in this commit.
Jacopo
On Jul 16, 2014, at 3:29 PM, jler...@apache.org wrote:
Author: jleroux
Date: Wed Jul 16 13:29:19 2014
New Revision: 1611002
URL: http://svn.apache.org/r1611002
Log:
An updated ands slightly modified patch from BJ
I forgot to save 1 formatting I did before committing, but for the var names I
have no ideas, you would like to rename port1?
Jacques
Le 16/07/2014 17:52, Jacopo Cappellato a écrit :
I see some ugly formatting and variable names in this commit.
Jacopo
On Jul 16, 2014, at 3:29 PM,
BTW I don't really care, but if I have done another pass at r1611246
Feel free to update if it's not really what you want
Jacques
Le 16/07/2014 23:56, Jacques Le Roux a écrit :
I forgot to save 1 formatting I did before committing, but for the var names I
have no ideas, you would like to
Thanks, it is better now but I still think that this contribution needed a more
accurate review: a catch block for NumberFormatException would be useful (to
log the configuration error as warning and set the default port value).
Jacopo
On Jul 17, 2014, at 6:52 AM, Jacques Le Roux
