Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-23 Thread Jacques Le Roux
Is there a classpath editor in Eclipse? Jacques Le 23/08/2015 11:35, Scott Gray a écrit : I've always assumed everybody manually edits the file directly rather than using the classpath editor. That why I used to try and keep it alphabetized. On 23 Aug 2015 00:19, Adrian Crum

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-23 Thread Scott Gray
I've always assumed everybody manually edits the file directly rather than using the classpath editor. That why I used to try and keep it alphabetized. On 23 Aug 2015 00:19, Adrian Crum adrian.c...@sandglass-software.com wrote: Thank you for fixing this Jacques! Adrian Crum Sandglass

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-23 Thread Adrian Crum
Project-Properties-Java Build Path-Libraries tab. Adrian Crum Sandglass Software www.sandglass-software.com On 8/23/2015 3:09 AM, Jacques Le Roux wrote: Is there a classpath editor in Eclipse? Jacques Le 23/08/2015 11:35, Scott Gray a écrit : I've always assumed everybody manually edits

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-23 Thread Jacques Le Roux
Ha OK thanks, I never thought it could be labelled a classpath editor :) Like Scott, I only used the XML editor and thought everybody was doing so Jacques Le 23/08/2015 14:20, Adrian Crum a écrit : Project-Properties-Java Build Path-Libraries tab. Adrian Crum Sandglass Software

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-23 Thread Scott Gray
Hence why it's always had spaces instead up tabs up until now :-) But no big deal, who cares really. Regards Scott On 24 August 2015 at 00:31, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Ha OK thanks, I never thought it could be labelled a classpath editor :) Like Scott, I only used

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-23 Thread Adrian Crum
I agree that it's not a big deal. There have been a few times when I was about to commit a change and I spotted the tabs, so I changed it back to spaces before committing. It's like that ftrue setting that we used to have somewhere. It kept confusing people so we changed it. Adrian Crum

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-22 Thread Adrian Crum
Thank you for fixing this Jacques! Adrian Crum Sandglass Software www.sandglass-software.com On 8/21/2015 2:11 PM, Jacques Le Roux wrote: OK I think I see your point now https://www.genuitec.com/forums/topic/eclipse-adding-to-classpath-file-uses-tabs/ Right? Jacques Le 21/08/2015 23:09,

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Shi Jinghai
Hi Jacques, Actually, only one line added in .classpath: classpathentry kind=lib path=framework/base/lib/zxing-core-3.2.0.jar/ It would be OK if it exists. Kind Regards, Shi Jinghai 在 2015年8月21日,下午8:47,Jacques Le Roux jacques.le.r...@les7arts.com 写道: Hi Jinghai, Are you sure you did

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Shi Jinghai
I guess it’s my fault … again. Thanks Jacques! 在 2015年8月21日,下午8:09,Adrian Crum adrian.c...@sandglass-software.com 写道: This should be reverted. Eclipse will turn the spaces back to tabs when it reads the file - so this change has no effect. Adrian Crum Sandglass Software

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Jacques Le Roux
Hi Jinghai, Are you sure you did not change too much things? I put back spaces instead of tabs but it seems there are more unwanted changes... Jacques Le 21/08/2015 14:03, jler...@apache.org a écrit : Author: jleroux Date: Fri Aug 21 12:03:00 2015 New Revision: 1696950 URL:

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Jacques Le Roux
The pb was more about easily seeing only the lines changed, not all. That's why I did so. I also prefer to have spaces rather than tabs in repo. Jacques Le 21/08/2015 14:09, Adrian Crum a écrit : This should be reverted. Eclipse will turn the spaces back to tabs when it reads the file - so

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Adrian Crum
Your preference is irrelevant. The format of the file is controlled by Eclipse, not by Jacques. We will continue to have this problem until the file format is corrected in the repo. Adrian Crum Sandglass Software www.sandglass-software.com On 8/21/2015 8:14 AM, Jacques Le Roux wrote: The pb

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Jacques Le Roux
OK I think I see your point now https://www.genuitec.com/forums/topic/eclipse-adding-to-classpath-file-uses-tabs/ Right? Jacques Le 21/08/2015 23:09, Jacques Le Roux a écrit : So you suggest we have now tabs instead of spaces in .classpath? Jacques Le 21/08/2015 22:31, Adrian Crum a écrit

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Adrian Crum
Tabs instead of spaces. Adrian Crum Sandglass Software www.sandglass-software.com On 8/21/2015 1:06 PM, Jacques Le Roux wrote: Le 21/08/2015 17:44, Adrian Crum a écrit : Your preference is irrelevant. The format of the file is controlled by Eclipse, not by Jacques. We will continue to have

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Jacques Le Roux
So you suggest we have now tabs instead of spaces in .classpath? Jacques Le 21/08/2015 22:31, Adrian Crum a écrit : Tabs instead of spaces. Adrian Crum Sandglass Software www.sandglass-software.com On 8/21/2015 1:06 PM, Jacques Le Roux wrote: Le 21/08/2015 17:44, Adrian Crum a écrit : Your

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Jacques Le Roux
I agree, it's just that, apart the tabs instead of spaces, your Eclipse version changed the way some lines were built. Thanks Jacques Le 21/08/2015 16:27, Shi Jinghai a écrit : Hi Jacques, Actually, only one line added in .classpath: classpathentry kind=lib

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Jacques Le Roux
Le 21/08/2015 17:44, Adrian Crum a écrit : Your preference is irrelevant. The format of the file is controlled by Eclipse, not by Jacques. We will continue to have this problem until the file format is corrected in the repo. What do you mean by file format? Jacques Adrian Crum Sandglass

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Adrian Crum
Correct. The format in our repo is wrong, and every new committer who changes a library in the project will have this same problem. If the file in the repo was in the correct format, then you would have seen what you wanted - only the file changes, not the whole file. Adrian Crum Sandglass

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Adrian Crum
This should be reverted. Eclipse will turn the spaces back to tabs when it reads the file - so this change has no effect. Adrian Crum Sandglass Software www.sandglass-software.com On 8/21/2015 5:03 AM, jler...@apache.org wrote: Author: jleroux Date: Fri Aug 21 12:03:00 2015 New Revision: