Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Right, I just fixed it it was r1757130. You may have found it by looking in the related Jira Thanks Jacques Le 30/08/2016 à 08:28, Scott Gray a écrit : Ok thanks, I guess you had a typo in your revert commit message because I couldn't find a mention of the original commit number when

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Ok thanks, I guess you had a typo in your revert commit message because I couldn't find a mention of the original commit number when searching. Regards Scott On 30 August 2016 at 17:58, Jacques Le Roux wrote: > Hi Scott, > > Yes, this has been reverted one week

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Scott, Yes, this has been reverted one week ago: https://issues.apache.org/jira/browse/OFBIZ-7966?focusedCommentId=15431090 Jacques Le 29/08/2016 à 23:38, Scott Gray a écrit : Hi Jacques, None whatsoever. I was just trying to offer a design that would truly decouple the tracking code

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Jacques, None whatsoever. I was just trying to offer a design that would truly decouple the tracking code functionality from the order component. Has this commit been reverted yet? I think that might be a good first step. Regards Scott On 29 August 2016 at 08:02, Jacques Le Roux

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

HI Scott, This sounds like an actionable plan, any plan to action it? Jacques Le 25/08/2016 à 07:38, Scott Gray a écrit : I was thinking that: 1. We need a means for the tracking code logic to be able to access the cookie data in the request without needing to add any logic to the order

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

I was thinking that: 1. We need a means for the tracking code logic to be able to access the cookie data in the request without needing to add any logic to the order component 2. We need a means for the order tracking code logic to be able to create TrackingCodeOrder records when the order is

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Scott, Thank you for the feedback. This is something I can work with. What I see now is the following: 1. compile-time dependency from order on marketing regarding the makeTrackingCodeOrders function 2. run-time dependencies from cmssite, ecommerce and webpos several other

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Pierre, Jacopo, Jacques, Sticking specifically to the commit being discussed, the beauty of the tracking code logic is that it effectively does nothing if you aren't using it. Granted TrackingCodeEvents.makeTrackingCodeOrders() could do with being improved so that it exits earlier if no

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Jacopo, Thank you for reacting. ERP solutions are, by their intent, modular in nature. This is driven by business requirements. And leads - by default - to runtime configuration. Which is especially important in multi-tenancy implementations. Some want solutions like cmssite, ecommerce and

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

That makes quite sense, thanks Jacopo! Jacques Le 23/08/2016 à 09:50, Jacopo Cappellato a écrit : Hi Pierre, cmssite, ecommerce and webpos are specialpurpose components that can rely on the artifacts (services, entities, labels, screens and *classes*) defined in the application component

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Pierre, cmssite, ecommerce and webpos are specialpurpose components that can rely on the artifacts (services, entities, labels, screens and *classes*) defined in the application component (including the "marketing" component to which TrackingCodeEvents belongs). With that said, there is a

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Jacopo, I see that most functions in TrackingCodeEvents.java are used in cmssite, ecommerce and webpos. Should we not convert all to services? Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Pierre, since Jacques responded to my mail, acknowledging that there are issues and that he is going to fix them, I will let him complete the work before digging into the code details. Anyway, they are pretty basic issues and I am concerned that you and Jacques couldn't identify them with your

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

I don't think it's 'completely wrong' but it's wrong indeed. Since I put a finger in it, and Pierre does not seems to see what the problem is, I'll finish it Jacques Le 22/08/2016 à 15:21, Pierre Smits a écrit : Hi Jacopo, Can you explain why it seems 'completely' wrong to you? Best

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Jacopo, Can you explain why it seems 'completely' wrong to you? Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Mon, Aug 22, 2016 at 12:43 PM, Jacopo Cappellato <

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

This contribution seems completely wrong to me. Pierre and Jacques, have you performed proper tests and reviews before committing it? Jacopo On Mon, Aug 22, 2016 at 11:58 AM, wrote: > Author: jleroux > Date: Mon Aug 22 09:58:35 2016 > New Revision: 1757130 > > URL: