Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Scott Gray
We should probably just have a vote on the contentious points and be done with it. The general consensus doesn't seem to be good enough for Jacques. Regards Scott On 13 September 2016 at 03:41, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > I am rather interested in knowing i

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 17:41, Jacopo Cappellato a écrit : I am rather interested in knowing if other committers share similar concerns or resistance to comply with the template as it is defined in the Wiki at the moment. If this is not the case then I think that Jacques should step back and stop this en

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Taher Alkhateeb
We write long emails, we write a lot of code, we write wiki pages, we write documentation, we write comments in Jiras and in fact what we do every day is write. Writing a few parentheses is hardly work especially since more than 90% of the time a commit is related to a single Jira. The effort we a

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacopo Cappellato
I am rather interested in knowing if other committers share similar concerns or resistance to comply with the template as it is defined in the Wiki at the moment. If this is not the case then I think that Jacques should step back and stop this endless thread that is not going anywhere. Jacopo

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 15:51, Jacques Le Roux a écrit : Again, I really don't see the need for the parenthesis. And I'd be happy to change that myself once in wiki and elsewhere it's needed rather than have to type it every time I commit (yes I commit a lot :p) Jacques By elsewhere above I mean I ca

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
Michael, inline... Le 12/09/2016 à 16:36, Michael Brohl a écrit : Am 12.09.16 um 15:51 schrieb Jacques Le Roux: Please do not start to question the blog style/format now, we use it for months, you reviewed it for month and did not raise such a question anytime in the past. Why now? Because, t

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Michael Brohl
Jacques, inline. Am 12.09.16 um 15:51 schrieb Jacques Le Roux: the parenthesis comes from our blog post format where we put the JIRA issue reference just behind the title (you know it because we are working together on this every month). Sorry, I did not notice this aspect. Do we really ne

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
I don't see the value of adding parenthesis everywhere. Remember this will stay forever in the project rules, except if someone has the guts to say no. Why would I want parenthesis there? Tell me! Jacques Le 12/09/2016 à 16:15, gil portenseigne a écrit : Hi Jacques, all, From my experience,

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 16:16, gil portenseigne a écrit : And moreover, Fixed over Fixes :) Le 12/09/2016 à 16:15, gil portenseigne a écrit : Fixes: Fix wrong menu name of NewPartyIdentification in screens Sorry I will stick with Fixes, at the moment I commit it's not yet fixed :p Jacques

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread gil portenseigne
And moreover, Fixed over Fixes :) Le 12/09/2016 à 16:15, gil portenseigne a écrit : Fixes: Fix wrong menu name of NewPartyIdentification in screens

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread gil portenseigne
Hi Jacques, all, From my experience, having a commit concerning lots of different JIRA is rare. In this case, don't you thinkthat the list of JIRAcould not be in the detail sectionand written in a more simple way OFBIZ-8118, OFBIZ-8122, OFBIZ-8123, etc. Indeed, in the commit message templa

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
Michael, Le 12/09/2016 à 14:30, Michael Brohl a écrit : Jacques, the parenthesis comes from our blog post format where we put the JIRA issue reference just behind the title (you know it because we are working together on this every month). Sorry, I did not notice this aspect. Do we really ne

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Michael Brohl
Jacques, the parenthesis comes from our blog post format where we put the JIRA issue reference just behind the title (you know it because we are working together on this every month). Of course, we can parse without the parenthesis and set them when we generate the development details. But a

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 11:37 AM, wrote: > Author: jleroux > Date: Mon Sep 12 09:37:11 2016 > New Revision: 1760325 > > URL: http://svn.apache.org/viewvc?rev=1760325&view=rev > Log: > Fixes: a bug introduced with one of > (OFBIZ-8118)(OFBIZ-8122)(OFBIZ-8123)(OFBIZ-8124)(OFBIZ- > 8125)(OFBIZ-8126)