I agree with Jacques and Deepak. The code is an improvement on what was
there, end of story. A contributor is a volunteer who is free to do as much
or as little as they please so long as each contribution is a full step
forward.
Regards
Scott
On 3/04/2017 17:13, "Deepak Dixit" wrote:
> I agree
I agree with Jacques,
it will also help to backport fixes to older releases.
If we mix them then it will difficult to identify the fix.
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
On Sun, Apr 2, 2017 at 5:28 PM, Taher Alkhateeb
wrote:
> Why not guide and mentor the contributor to
+1
It would be good to do refactoring/cleanup when code is changed or at least
file a Jira when there is no time to do it all at once.
Let's apply this as a pattern and keep eyes open.
Regards,
Michael
> Am 02.04.2017 um 13:58 schrieb Taher Alkhateeb :
>
> Why not guide and mentor the contr
Thanks for your help
Jacques
Le 02/04/2017 à 13:58, Taher Alkhateeb a écrit :
Why not guide and mentor the contributor to change the list to a grid in
the same commit? Why do the work twice?
If we use the logic of "not mix things" then anytime we work on a piece of
code we don't refactor it b
Why not guide and mentor the contributor to change the list to a grid in
the same commit? Why do the work twice?
If we use the logic of "not mix things" then anytime we work on a piece of
code we don't refactor it because we should "not mix things". That just
doesn't make a lot of sense to me. Any
I prefer to not mix things in a patch from a contributor.
But yes the grid is slowly replacing the list form.
Jacques
Le 02/04/2017 à 12:47, Taher Alkhateeb a écrit :
I am a little confused! You had many commits in the past where you are
converting list-forms into grids (I even had some quest
