Hi Deepak,
I had to revert. I also added a better comment for future. Please see
OFBIZ-9385 for details if necessary
Jacques
Le 06/12/2022 à 19:21, Jacques Le Roux a écrit :
Hi,
The last commit is a problem as mentioned today in OFBIZ-9385
I'll see tomorrow morning...
Jacques
Le
Hi,
The last commit is a problem as mentioned today in OFBIZ-9385
I'll see tomorrow morning...
Jacques
Le 05/12/2022 à 12:50, Jacques Le Roux a écrit :
Thanks Deepak,
Done as suggested
Jacques
Le 05/12/2022 à 06:18, Deepak Dixit a écrit :
I am working on some performance related thing,
Thanks Deepak,
Done as suggested
Jacques
Le 05/12/2022 à 06:18, Deepak Dixit a écrit :
I am working on some performance related thing, while reviewing code I
found the code snippet where eli closed explicitly,
That's why I landed up on this commit.
Please feel free to revert this commit,
We
I am working on some performance related thing, while reviewing code I
found the code snippet where eli closed explicitly,
That's why I landed up on this commit.
Please feel free to revert this commit,
We can also remove explicitly eli.close call from handleOutput(), else will
get unnecessary
Hi Deepak,
You are right, I missed to conclude what I said at the end of the commit comment ("I
have to check the whole thing").
So did not see that the called handleOutput() closes the eli var, well spotted.
Now if we look at both r1797097
Hi Jacques,
I know it's quite an old commit :)
Do you remember the case where eli closed after the returned list has been
used?
As handleOutput method closes the eli inline.
I am planning to revert this commit, Please share your thoughts.
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org
