Re: svn commit: r1819730 [1/6] - in /ofbiz/ofbiz-framework/trunk/applications: content/src/main/java/org/apache/ofbiz/content/ content/src/main/java/org/apache/ofbiz/content/compdoc/ content/src/main/

2018-01-01 Thread Jacques Le Roux
Le 01/01/2018 à 13:13, Michael Brohl a écrit : I won't insist on this further. There seems to be a substantial difference in perception how we should handle these issues and I'm tired to discuss this again and again. Hope you will take care about the fixes resulting from the commit if they are ne

Re: svn commit: r1819730 [1/6] - in /ofbiz/ofbiz-framework/trunk/applications: content/src/main/java/org/apache/ofbiz/content/ content/src/main/java/org/apache/ofbiz/content/compdoc/ content/src/main/

2018-01-01 Thread Taher Alkhateeb
We had this discussion too many times. Big mass-changes that are unfocused are a bad idea. We've witnessed many issues in the past and the info is available in other threads. I wish if Jacques would stop these massive lets-go-after-a-pattern-everywhere kind of commits. I leave it for the rest of t

Re: svn commit: r1819730 [1/6] - in /ofbiz/ofbiz-framework/trunk/applications: content/src/main/java/org/apache/ofbiz/content/ content/src/main/java/org/apache/ofbiz/content/compdoc/ content/src/main/

2018-01-01 Thread Jacques Le Roux
Le 01/01/2018 à 12:45, Jacques Le Roux a écrit : 2. When in trunk they can be "hand" and "automatically" (thanks to spiders) tested, in demo. Also by people running them on their machine. They are    not supposed to be used in production of course. Of course I'd not do that just before freezing

Re: svn commit: r1819730 [1/6] - in /ofbiz/ofbiz-framework/trunk/applications: content/src/main/java/org/apache/ofbiz/content/ content/src/main/java/org/apache/ofbiz/content/compdoc/ content/src/main/

2017-12-31 Thread Michael Brohl
I have not the time to look at this further now but some changes seem to change the business logic, e.g. by returning an "error" result in events where they did not before, same in services. It makes a difference in both the controller logic as well as in the service engine logic. This seems n

Re: svn commit: r1819730 [1/6] - in /ofbiz/ofbiz-framework/trunk/applications: content/src/main/java/org/apache/ofbiz/content/ content/src/main/java/org/apache/ofbiz/content/compdoc/ content/src/main/

2017-12-31 Thread Taher Alkhateeb
I don't know what the rest of the team thinks, but I am really worried from this commit. It is one of those mass updates which I constantly warn against. Can you please clarify what kind of testing was done against all the services that were updated and the context of each service? On Sun, Dec 31