Re: svn commit: r1838381 - in /ofbiz: ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ ofbiz-framework/trunk/applications/product/groovyScripts/catalog/find/ ofbiz-plugins/trunk/e

2018-08-20 Thread Jacques Le Roux
Thanks Deepak, I also suppose the session has always a delegator in. Because we can always get a delegator from the dispatcher, not the reverse, if I would get this way, to keep things consistent, I would verify that session has always a dispatcher in, and document it in the screen variable

Re: svn commit: r1838381 - in /ofbiz: ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ ofbiz-framework/trunk/applications/product/groovyScripts/catalog/find/ ofbiz-plugins/trunk/e

2018-08-20 Thread Deepak Dixit
Thanks Jacques, I added this in my TODO list, I agree with Michael's comment. I'll check and create a ticket if needed. Thanks & Regards -- Deepak Dixit On Mon, Aug 20, 2018 at 12:36 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Deepak, > > I used this way because it starts

Re: svn commit: r1838381 - in /ofbiz: ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ ofbiz-framework/trunk/applications/product/groovyScripts/catalog/find/ ofbiz-plugins/trunk/e

2018-08-20 Thread Jacques Le Roux
Please open a Jira if you think that we normally expect the dispatcher to be always in the session I don't know if a such rule exists. And this is not related with the work I did in OFBIZ-9164 Jacques Le 20/08/2018 à 12:06, Taher Alkhateeb a écrit : Agreed, surface level fixes are not

Re: svn commit: r1838381 - in /ofbiz: ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ ofbiz-framework/trunk/applications/product/groovyScripts/catalog/find/ ofbiz-plugins/trunk/e

2018-08-20 Thread Taher Alkhateeb
Agreed, surface level fixes are not good, you might have a logic flaw underneath. We should always go for root cauae analysis. On Mon, Aug 20, 2018, 1:00 PM Michael Brohl wrote: > Jacques, > > inline... > > Am 20.08.18 um 11:27 schrieb Jacques Le Roux: > > Hi Michael, > > > > Yes but at this

Re: svn commit: r1838381 - in /ofbiz: ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ ofbiz-framework/trunk/applications/product/groovyScripts/catalog/find/ ofbiz-plugins/trunk/e

2018-08-20 Thread Michael Brohl
Jacques, inline... Am 20.08.18 um 11:27 schrieb Jacques Le Roux: Hi Michael, Yes but at this point the session misses the dispatcher, that's why I use    request.getSession().setAttribute("dispatcher",dispatcher) to put it in. As shown at

Re: svn commit: r1838381 - in /ofbiz: ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ ofbiz-framework/trunk/applications/product/groovyScripts/catalog/find/ ofbiz-plugins/trunk/e

2018-08-20 Thread Jacques Le Roux
Hi Michael, Yes but at this point the session misses the dispatcher, that's why I use request.getSession().setAttribute("dispatcher",dispatcher) to put it in. As shown at https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context  the dispatcher is

Re: svn commit: r1838381 - in /ofbiz: ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ ofbiz-framework/trunk/applications/product/groovyScripts/catalog/find/ ofbiz-plugins/trunk/e

2018-08-20 Thread Michael Brohl
Hi Jacques, maybe I am missing something but you should be able to get the session with request.getSession(), no? Regards, Michael Am 20.08.18 um 09:06 schrieb Jacques Le Roux: Hi Deepak, I used this way because it starts in Groovy with    

Re: svn commit: r1838381 - in /ofbiz: ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ ofbiz-framework/trunk/applications/product/groovyScripts/catalog/find/ ofbiz-plugins/trunk/e

2018-08-20 Thread Jacques Le Roux
Hi Deepak, I used this way because it starts in Groovy with     ProductSearchSession.getProductSearchResult(request, delegator, prodCatalogId) the session is not in the request, and there is no alternative signature for ProductSearchSession::getProductSearchResult As I did not want to get too

Re: svn commit: r1838381 - in /ofbiz: ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ ofbiz-framework/trunk/applications/product/groovyScripts/catalog/find/ ofbiz-plugins/trunk/e

2018-08-19 Thread Deepak Dixit
Hi Jacques, I think instead of setting dispatcher in groovy files I think we can fix the work done under OFBIZ-9164 Instead of getting dispatcher from a session we can get this from the request or can use the different method signature of searchGetConstraintStrings method. {code}