Re: svn commit: r1856618 - in /ofbiz/ofbiz-plugins/trunk/msg91: ./ config/ data/ data/helpdata/ documents/ entitydef/ servicedef/ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apa

2019-04-12 Thread Jacques Le Roux
+1, thanks Rishi! Le 12/04/2019 à 12:02, Rishi Solanki a écrit : Jacques, Thanks for pointing this, I made code changes before committing this as plugin. And as we uses free services from them (by mentioning OFBiz as open source apache software) so didn't give a thought to name of component and

Re: svn commit: r1856618 - in /ofbiz/ofbiz-plugins/trunk/msg91: ./ config/ data/ data/helpdata/ documents/ entitydef/ servicedef/ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apa

2019-04-12 Thread Rishi Solanki
Jacques, Thanks for pointing this, I made code changes before committing this as plugin. And as we uses free services from them (by mentioning OFBiz as open source apache software) so didn't give a thought to name of component and mentioning of commercial services. I'm completely agree with you

Re: svn commit: r1856618 - in /ofbiz/ofbiz-plugins/trunk/msg91: ./ config/ data/ data/helpdata/ documents/ entitydef/ servicedef/ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apa

2019-04-11 Thread Jacques Le Roux
Hi Rishi, In understand that this component currently uses "msg91 services to send sms". But could we not have another name, more explicit, for this component, like sms or sendsms for instance? Services tend to disappear or change (Google is the best example). So I'd not associate the name of