Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-07 Thread Jacques Le Roux
I had a look at this idea but I finally gave up. I thought about creating     public static Map testGroovy(Map paramNames, String serviceName) {     userLogin = EntityQuery.use(delegator).from('UserLogin').where('userLoginId', 'system').cache().queryOne()     Map serviceCtx =

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-05 Thread Suraj Khurana
Sure Jacques. You can definitely proceed with the available patches. Not an issue at all. We all are part of this dynamic community where we work together as a team. :) Thanks a lot for asking and taking care of this. -- Best Regards, Suraj Khurana Technical Consultant HotWax Systems On

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-05 Thread Jacques Le Roux
If you don't mind Suraj, I'll commit the available patches Jacques Le 03/10/2019 à 13:40, Jacques Le Roux a écrit : I agree Suraj, Jacques Le 03/10/2019 à 11:25, Suraj Khurana a écrit : Hello Jacques/Mathieu, I think we can use the same ticket with new patch, WDYT. (If it is not closed)

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-03 Thread Jacques Le Roux
BTW looking at OrderTests.groovy it seems we can refactor Groovy tests, a lot of is common... Jacques Le 03/10/2019 à 13:33, Jacques Le Roux a écrit : r1867927 is the answer Jacques Le 03/10/2019 à 12:10, Mathieu Lirzin a écrit : Hello Jacques, Jacques Le Roux writes: Le 02/10/2019 à

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-03 Thread Jacques Le Roux
I agree Suraj, Jacques Le 03/10/2019 à 11:25, Suraj Khurana a écrit : Hello Jacques/Mathieu, I think we can use the same ticket with new patch, WDYT. (If it is not closed) We have been following this pattern since last many commits under OFBIZ-1463. Currently, I think most of the Patch

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-03 Thread Jacques Le Roux
r1867927 is the answer Jacques Le 03/10/2019 à 12:10, Mathieu Lirzin a écrit : Hello Jacques, Jacques Le Roux writes: Le 02/10/2019 à 17:21, Mathieu Lirzin a écrit : jler...@apache.org writes: Author: jleroux Date: Wed Oct 2 14:46:00 2019 New Revision: 1867889 URL:

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-03 Thread Jacques Le Roux
Hi Suraj, Actually those assigned to Yogesh Naroliya have XML patches and needs cleaning. After doing it for OFBIZ-8810 and OFBIZ-8811, I find quite easy to convert those tests to Groovy, WIP... Jacques Le 03/10/2019 à 11:25, Suraj Khurana a écrit : Hello Jacques/Mathieu, I think we can

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-03 Thread Mathieu Lirzin
Hello Jacques, Jacques Le Roux writes: > Le 02/10/2019 à 17:21, Mathieu Lirzin a écrit : > >> jler...@apache.org writes: >> >>> Author: jleroux >>> Date: Wed Oct 2 14:46:00 2019 >>> New Revision: 1867889 >>> >>> URL: http://svn.apache.org/viewvc?rev=1867889=rev >>> Log: >>> Improved: Unit test

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-03 Thread Suraj Khurana
Hello Jacques/Mathieu, I think we can use the same ticket with new patch, WDYT. (If it is not closed) We have been following this pattern since last many commits under OFBIZ-1463. Currently, I think most of the Patch Available tickets under OFBIZ-1463 have converted groovy patch. Only 2 tickets

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-03 Thread Jacques Le Roux
Le 03/10/2019 à 09:34, Jacques Le Roux a écrit : But you are right and I'll open new Jiras for migrating them, knowing that we have a 1300+ others tests to migrate[1]! (ie here it's 1%+, and I expect simple ones :)) Started with OFBIZ-11232 Jacques

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-03 Thread Jacques Le Roux
Hi Mathieu, Le 02/10/2019 à 17:21, Mathieu Lirzin a écrit : Hello Jacques, jler...@apache.org writes: Author: jleroux Date: Wed Oct 2 14:46:00 2019 New Revision: 1867889 URL: http://svn.apache.org/viewvc?rev=1867889=rev Log: Improved: Unit test case for service -

Re: svn commit: r1867889 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/OrderDemoData.xml order/minilang/test/OrderTest.xml order/servicedef/secas.xml order/testdef/OrderTest.xml

2019-10-02 Thread Mathieu Lirzin
Hello Jacques, jler...@apache.org writes: > Author: jleroux > Date: Wed Oct 2 14:46:00 2019 > New Revision: 1867889 > > URL: http://svn.apache.org/viewvc?rev=1867889=rev > Log: > Improved: Unit test case for service - SendOrderBackorderNotification > (OFBIZ-8810)(OFBIZ-9647)(OFBIZ-9671) > >