Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy

2020-04-27 Thread Suraj Khurana
Thanks Jacques for taking care of it. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Apr 27, 2020 at 9:43 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > I don't remember if it was intentional, I think I missed them and will add > them "right now" > > Thanks > > L

Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy

2020-04-27 Thread Jacques Le Roux
I don't remember if it was intentional, I think I missed them and will add them "right now" Thanks Le 27/04/2020 à 12:36, Suraj Khurana a écrit : I meant, in the XML version we were sending note (Test note) and comments (Test Comments) as well in serviceCtx, but in the converted version we are

Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy

2020-04-27 Thread Suraj Khurana
I meant, in the XML version we were sending note (Test note) and comments (Test Comments) as well in serviceCtx, but in the converted version we are not sending these fields. Tests will pass for sure, as they are not mandatory to send. -- Best Regards, Suraj Khurana Senior Technical Consultant

Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy

2020-04-27 Thread Jacques Le Roux
Hi Suraj, If you mean that there is no explanation but "Tests pass", as it's Svn we can still amend it, what would you suggest? Thanks Jacques Le 27/04/2020 à 08:47, Suraj Khurana a écrit : Hello Jacques, I think we missed the note, comments field during conversion in this commit. Is it int

Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy

2020-04-26 Thread Suraj Khurana
Hello Jacques, I think we missed the note, comments field during conversion in this commit. Is it intentional, or am I missing something? -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Oct 3, 2019 at 5:00 PM wrote: > Author: jleroux > Date: Thu Oct 3 11:30:28 2019 > New Re