Re: svn commit: r619566 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ModelScreenWidget.java

2008-02-07 Thread David E Jones
That's totally fine, you can certainly adjust instead of revert. The main point is that every time a form (or screen or ftl or whatever) is rendered that the cache entry for it gets hit. -David On Feb 7, 2008, at 12:35 PM, Adrian Crum wrote: Thanks for your comments David. I still need th

Re: svn commit: r619566 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ModelScreenWidget.java

2008-02-07 Thread Adrian Crum
Thanks for your comments David. I still need the accessor methods for some screen widget enhancements I'm working on. So instead of reverting, I'll change the code a bit. -Adrian David E Jones wrote: This is an okay pattern Adrian, but one that is avoided in most parts of the framework. T

Re: svn commit: r619566 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ModelScreenWidget.java

2008-02-07 Thread David E Jones
This is an okay pattern Adrian, but one that is avoided in most parts of the framework. The reason is caching and a balance between production performance and development convenience. In production looking up a local field in an object is definitely faster than doing a Map lookup, but n