Re: svn commit: r662654 - in /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/visit: showvisits.groovy visitdetail.groovy

2008-06-03 Thread Jacques Le Roux
+1 Jacques From: "Joe Eckard" <[EMAIL PROTECTED]> Since we're still in the initial stage of converting beanshell scripts to groovy, I would like to propose that when renaming files, we uppercase the filenames. (e.g product.bsh becomes Product.groovy) The main reason for this is that when a

Re: svn commit: r662654 - in /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/visit: showvisits.groovy visitdetail.groovy

2008-06-03 Thread Joe Eckard
Since we're still in the initial stage of converting beanshell scripts to groovy, I would like to propose that when renaming files, we uppercase the filenames. (e.g product.bsh becomes Product.groovy) The main reason for this is that when a script is run without a class declaration, the fil

Re: svn commit: r662654 - in /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/visit: showvisits.groovy visitdetail.groovy

2008-06-02 Thread Ashish Vijaywargiya
Scott, I am feeling very happy to see your positive comments on my commit. I noted down the points specified by you and will try to include those in my upcoming commit in this area. -- Ashish On Tue, Jun 3, 2008 at 2:18 AM, Scott Gray <[EMAIL PROTECTED]> wrote: > Hi Ashish > > Everything looks

Re: svn commit: r662654 - in /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/visit: showvisits.groovy visitdetail.groovy

2008-06-02 Thread Scott Gray
Hi Ashish Everything looks fine, just a couple of (hopefully) helpful tips: There is a shortened version of java ternary operator available "?:" which provides a default if the rhs of an assignment resolves to null or false: Instead of showAll = parameters.showAll; if (!showAll) { showAll = "f