Re: svn commit: r795030 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/finaccount/FinAccountServices.xml

2009-07-17 Thread Ashish Vijaywargiya
+1 on Adrian's comment. -- Ashish On Fri, Jul 17, 2009 at 7:53 PM, Adrian Crum wrote: > I don't see where using UEL expressions is any different than using > BeanShell scriptlets: ${bsh:payment.statusId == 'PMNT_SENT' @or > payment.statusId == 'PMNT_RECEIVED';} - which are used a lot in the pro

Re: svn commit: r795030 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/finaccount/FinAccountServices.xml

2009-07-17 Thread Adrian Crum
I don't see where using UEL expressions is any different than using BeanShell scriptlets: ${bsh:payment.statusId == 'PMNT_SENT' @or payment.statusId == 'PMNT_RECEIVED';} - which are used a lot in the project. The code could be simplified further by using: property="AccountingPaymentStatus

Re: svn commit: r795030 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/finaccount/FinAccountServices.xml

2009-07-17 Thread Hans Bakker
I am sorry but the xml definition was much more clear and the whole equation togetherthe separate 'false' with uel not nice On Fri, 2009-07-17 at 16:24 +0530, Chirag Manocha wrote: > Comments Inline :- > > Hans Bakker wrote: > > Are you sure this is correct? > > > > In the original compa

Re: svn commit: r795030 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/finaccount/FinAccountServices.xml

2009-07-17 Thread Chirag Manocha
Comments Inline :- Hans Bakker wrote: Are you sure this is correct? In the original comparison there is a 'not' around the 'or' which i do not see in the UEL I also do not see much advantages in these kind of changes they only can create problems Regards, Hans On Fri, 2009-07-17 a

Re: svn commit: r795030 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/finaccount/FinAccountServices.xml

2009-07-17 Thread Hans Bakker
Are you sure this is correct? In the original comparison there is a 'not' around the 'or' which i do not see in the UEL I also do not see much advantages in these kind of changes they only can create problems Regards, Hans On Fri, 2009-07-17 at 10:23 +, apa...@apache.org wrote: >