Re: svn commit: r883017 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

2009-11-26 Thread Adam Heath
Jacques Le Roux wrote: > From: "Jacques Le Roux" >> BTW, you did not mention anyting about >>if (countriesAvailable != null) { >> This would be my main concern. I want to refactor StringUtil .split >> (and uses) so that it renders an empty list when now it's >> rendering null. To avoid this us

Re: svn commit: r883017 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

2009-11-26 Thread Jacques Le Roux
From: "Jacques Le Roux" BTW, you did not mention anyting about if (countriesAvailable != null) { This would be my main concern. I want to refactor StringUtil .split (and uses) so that it renders an empty list when now it's rendering null. To avoid this useless check when using an enhanced fo

Re: svn commit: r883017 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

2009-11-26 Thread Jacques Le Roux
From: "Jacques Le Roux" Hi Scott, 1st I find Marco's idea very good! And I'd like to apply it also to languages. Who needs all languages ? Of course if you use only one language (English ;o) you can't see that as a drawback, but when you have continuously to change from one language to Engli

Re: svn commit: r883017 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

2009-11-25 Thread Jacques Le Roux
Hi Scott, 1st I find Marco's idea very good! And I'd like to apply it also to languages. Who needs all languages ? Of course if you use only one language (English ;o) you can't see that as a drawback, but when you have continuously to change from one language to English, it can be boring... So

Re: svn commit: r883017 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

2009-11-21 Thread Scott Gray
On 22/11/2009, at 1:20 PM, jler...@apache.org wrote: Author: jleroux Date: Sun Nov 22 00:20:12 2009 New Revision: 883017 URL: http://svn.apache.org/viewvc?rev=883017&view=rev Log: A modified patch from Marco Risailit " Add the possibility to filter the list of available countries from the dro